public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix usb buffer size for large descriptor of devices
Date: Sun, 5 May 2013 23:37:09 +0200	[thread overview]
Message-ID: <201305052337.09902.marex@denx.de> (raw)
In-Reply-To: <1366564518-10324-1-git-send-email-kwizart@gmail.com>

Dear Nicolas Chauvet,

> scanning bus 0 for devices...
> usb_get_configuration_no: failed to get descriptor - too long: 943
> 
> This was experienced on toshiba ac100 aka paz00, when discovering
> the webcam.
> 
> This patch is probably wrong, as it raise the buffer for all usb.
> Instead it could probably be raised only per target system of maybe
> per kind of devices

It'd be nice to CC me, it'd greatly raise your chance of getting a reply.

btw. why dont you allocate it dynamically then?

> ---
>  common/usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/usb.c b/common/usb.c
> index 6fc0fc1..46f5ce5 100644
> --- a/common/usb.c
> +++ b/common/usb.c
> @@ -68,7 +68,7 @@
>  #define USB_PRINTF(fmt, args...)	debug_cond(USB_DEBUG, fmt, ##args)
>  #define USB_HUB_PRINTF(fmt, args...)	debug_cond(USB_HUB_DEBUG, fmt,
> ##args)
> 
> -#define USB_BUFSIZ	512
> +#define USB_BUFSIZ	1024
> 
>  static struct usb_device usb_dev[USB_MAX_DEVICE];
>  static int dev_index;

Best regards,
Marek Vasut

      reply	other threads:[~2013-05-05 21:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-21 17:15 [U-Boot] [PATCH] Fix usb buffer size for large descriptor of devices Nicolas Chauvet
2013-05-05 21:37 ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305052337.09902.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox