[U-Boot] [PATCH] Fix usb buffer size for large descriptor of devices

[U-Boot] [PATCH] Fix usb buffer size for large descriptor of devices

[Nicolas Chauvet]

scanning bus 0 for devices...
usb_get_configuration_no: failed to get descriptor - too long: 943

This was experienced on toshiba ac100 aka paz00, when discovering
the webcam.

This patch is probably wrong, as it raise the buffer for all usb.
Instead it could probably be raised only per target system of maybe
per kind of devices
---
 common/usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/usb.c b/common/usb.c
index 6fc0fc1..46f5ce5 100644
--- a/common/usb.c
+++ b/common/usb.c
@@ -68,7 +68,7 @@
 #define USB_PRINTF(fmt, args...)	debug_cond(USB_DEBUG, fmt, ##args)
 #define USB_HUB_PRINTF(fmt, args...)	debug_cond(USB_HUB_DEBUG, fmt, ##args)
 
-#define USB_BUFSIZ	512
+#define USB_BUFSIZ	1024
 
 static struct usb_device usb_dev[USB_MAX_DEVICE];
 static int dev_index;
-- 
1.7.11.7

[U-Boot] [PATCH] Fix usb buffer size for large descriptor of devices

[Marek Vasut]

Dear Nicolas Chauvet,

> scanning bus 0 for devices...
> usb_get_configuration_no: failed to get descriptor - too long: 943
> 
> This was experienced on toshiba ac100 aka paz00, when discovering
> the webcam.
> 
> This patch is probably wrong, as it raise the buffer for all usb.
> Instead it could probably be raised only per target system of maybe
> per kind of devices

It'd be nice to CC me, it'd greatly raise your chance of getting a reply.

btw. why dont you allocate it dynamically then?

> ---
>  common/usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/usb.c b/common/usb.c
> index 6fc0fc1..46f5ce5 100644
> --- a/common/usb.c
> +++ b/common/usb.c
> @@ -68,7 +68,7 @@
>  #define USB_PRINTF(fmt, args...)	debug_cond(USB_DEBUG, fmt, ##args)
>  #define USB_HUB_PRINTF(fmt, args...)	debug_cond(USB_HUB_DEBUG, fmt,
> ##args)
> 
> -#define USB_BUFSIZ	512
> +#define USB_BUFSIZ	1024
> 
>  static struct usb_device usb_dev[USB_MAX_DEVICE];
>  static int dev_index;

Best regards,
Marek Vasut