* [U-Boot] [PATCH] Fix usb buffer size for large descriptor of devices
@ 2013-04-21 17:15 Nicolas Chauvet
2013-05-05 21:37 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Chauvet @ 2013-04-21 17:15 UTC (permalink / raw)
To: u-boot
scanning bus 0 for devices...
usb_get_configuration_no: failed to get descriptor - too long: 943
This was experienced on toshiba ac100 aka paz00, when discovering
the webcam.
This patch is probably wrong, as it raise the buffer for all usb.
Instead it could probably be raised only per target system of maybe
per kind of devices
---
common/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/usb.c b/common/usb.c
index 6fc0fc1..46f5ce5 100644
--- a/common/usb.c
+++ b/common/usb.c
@@ -68,7 +68,7 @@
#define USB_PRINTF(fmt, args...) debug_cond(USB_DEBUG, fmt, ##args)
#define USB_HUB_PRINTF(fmt, args...) debug_cond(USB_HUB_DEBUG, fmt, ##args)
-#define USB_BUFSIZ 512
+#define USB_BUFSIZ 1024
static struct usb_device usb_dev[USB_MAX_DEVICE];
static int dev_index;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] Fix usb buffer size for large descriptor of devices
2013-04-21 17:15 [U-Boot] [PATCH] Fix usb buffer size for large descriptor of devices Nicolas Chauvet
@ 2013-05-05 21:37 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2013-05-05 21:37 UTC (permalink / raw)
To: u-boot
Dear Nicolas Chauvet,
> scanning bus 0 for devices...
> usb_get_configuration_no: failed to get descriptor - too long: 943
>
> This was experienced on toshiba ac100 aka paz00, when discovering
> the webcam.
>
> This patch is probably wrong, as it raise the buffer for all usb.
> Instead it could probably be raised only per target system of maybe
> per kind of devices
It'd be nice to CC me, it'd greatly raise your chance of getting a reply.
btw. why dont you allocate it dynamically then?
> ---
> common/usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/usb.c b/common/usb.c
> index 6fc0fc1..46f5ce5 100644
> --- a/common/usb.c
> +++ b/common/usb.c
> @@ -68,7 +68,7 @@
> #define USB_PRINTF(fmt, args...) debug_cond(USB_DEBUG, fmt, ##args)
> #define USB_HUB_PRINTF(fmt, args...) debug_cond(USB_HUB_DEBUG, fmt,
> ##args)
>
> -#define USB_BUFSIZ 512
> +#define USB_BUFSIZ 1024
>
> static struct usb_device usb_dev[USB_MAX_DEVICE];
> static int dev_index;
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-05 21:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-21 17:15 [U-Boot] [PATCH] Fix usb buffer size for large descriptor of devices Nicolas Chauvet
2013-05-05 21:37 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox