public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] mx23: Operate DDR voltage supply at 2.5V
Date: Mon, 6 May 2013 04:19:28 +0200	[thread overview]
Message-ID: <201305060419.29098.marex@denx.de> (raw)
In-Reply-To: <1367805176-16156-1-git-send-email-festevam@gmail.com>

Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> After the recent fixes in the mx23 DDR setup, it is safe to operate DDR
> voltage at the recommended 2.5V voltage level again.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Is this a tripple revert ?

Stefano, you can apply this before applying the patches I complained weren't 
applied a few hours ago, it'll prevent merge conflict. Esp. this [PATCH] arm: 
mx23: Fix VDDMEM misconfiguration

> ---
>  arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c index 41fb803..4ed197b 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> @@ -247,7 +247,7 @@ static void mx23_mem_setup_vddmem(void)
>  	struct mxs_power_regs *power_regs =
>  		(struct mxs_power_regs *)MXS_POWER_BASE;
> 
> -	writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) |
> +	writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) |
>  		POWER_VDDMEMCTRL_ENABLE_ILIMIT |
>  		POWER_VDDMEMCTRL_ENABLE_LINREG |
>  		POWER_VDDMEMCTRL_PULLDOWN_ACTIVE,
> @@ -255,7 +255,7 @@ static void mx23_mem_setup_vddmem(void)
> 
>  	early_delay(10000);
> 
> -	writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) |
> +	writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) |
>  		POWER_VDDMEMCTRL_ENABLE_LINREG,
>  		&power_regs->hw_power_vddmemctrl);
>  }

Best regards,
Marek Vasut

  parent reply	other threads:[~2013-05-06  2:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06  1:52 [U-Boot] [PATCH 1/3] mx23: Operate DDR voltage supply at 2.5V Fabio Estevam
2013-05-06  1:52 ` [U-Boot] [PATCH 2/3] mx23evk: Do not set voltage selection bit for SSP pads Fabio Estevam
2013-05-06  2:20   ` Marek Vasut
2013-05-06  2:24     ` Fabio Estevam
2013-05-06  2:29       ` Marek Vasut
2013-05-06  2:33         ` Fabio Estevam
2013-05-06  2:38           ` Marek Vasut
2013-05-06  7:57   ` Stefano Babic
2013-05-06  1:52 ` [U-Boot] [PATCH 3/3] mx23_olinuxino: " Fabio Estevam
2013-05-06  2:20   ` Marek Vasut
2013-05-06  7:58   ` Stefano Babic
2013-05-06  2:19 ` Marek Vasut [this message]
2013-05-06  7:57 ` [U-Boot] [PATCH 1/3] mx23: Operate DDR voltage supply at 2.5V Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305060419.29098.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox