[U-Boot] [PATCH v6 03/12] nand: add Faraday FTNANDC021 NAND controller support

Kuo-Jung Su
2013-07-09T01:42:01Z

2013/7/9 Scott Wood <scottwood@freescale.com>:
> On 07/03/2013 10:40:35 PM, Kuo-Jung Su wrote:
>>
>> +#ifndef __ARMEB__
>> + put_unaligned_le32(readl(&regs->dr), buf + off);
>> +#else
>> + put_unaligned_be32(readl(&regs->dr), buf + off);
>> +#endif
>
>
> Can't you just use plain put_unaligned()? Be sure to cast buf + off to a
> 32-bit pointer.
>

Ummm... I think it'll be better to replace put_unaligned() with memcpy(),
just like what your suggested before.

So that we don't even have to worry about this endian issue and pointer cast.

> Also, when you *do* need to have an if/else, use positive logic -- ifdef
> rather than ifndef, with the if/else swapped.
>

Got it, thanks

--
Best wishes,
Kuo-Jung Su