[U-Boot] [PATCH v3 09/11] usb: gadget: add Faraday FOTG210 USB gadget support

Kuo-Jung Su
2013-04-29T03:11:49Z

2013/4/26 Marek Vasut <marex@denx.de>:
> Dear Kuo-Jung Su,
>
>> From: Kuo-Jung Su <dantesu@faraday-tech.com>
>>
>> The Faraday FOTG210 is an OTG chip which could operate
>> as either an EHCI Host or a USB Device as a time.
>>
>> Signed-off-by: Kuo-Jung Su <dantesu@faraday-tech.com>
>> CC: Marek Vasut <marex@denx.de>
>
> Same rambling as for the other patch, bits should have proper names defined in
> the fotg_....h header file.

Got it, thanks

> You should avoid calling
> dcache_enable()/dcache_disable() throughout the driver, why do you need to do
> that? Rather implement proper cacheline flushing/invalidation.
>

Sorry, it's my debug codes in the old days, it would be cleanup later

> Best regards,
> Marek Vasut

--
Best wishes,
Kuo-Jung Su