From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 8 May 2013 19:26:01 +0200 Subject: [U-Boot] [PATCH] ARM: cfi_flash: Fix unaligned accesses to cfi_qry structure In-Reply-To: <1367228070-6351-1-git-send-email-andrew_gabbasov@mentor.com> References: <1367228070-6351-1-git-send-email-andrew_gabbasov@mentor.com> Message-ID: <201305081926.01516.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Andrew Gabbasov, > Packed structure cfi_qry contains unaligned 16- and 32-bits members, > accessing which causes problems when cfi_flash driver is compiled with > -munaligned-access option: flash initialization hangs, probably > due to data error. > > This fix converts 16- and 32-bit members to byte arrays and uses special > macros to access such fields. It removes possible unaligned accesses > in cfi_flash driver. > > Signed-off-by: Andrew Gabbasov It seems OK. I just wonder if the le16_to_cpu you removed can have no impact now on obscure-endian architectures, that's my only concern. Best regards, Marek Vasut