From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] usb: Correct CLEAR_FEATURE code in ehci-hcd
Date: Sat, 11 May 2013 19:59:37 +0200 [thread overview]
Message-ID: <201305111959.38111.marex@denx.de> (raw)
In-Reply-To: <CAPnjgZ0E5+G6=w8qmELhONeCjQBxt2fTCOUkK+TEOgnRrZbW4w@mail.gmail.com>
Dear Simon Glass,
> On Sat, May 11, 2013 at 10:39 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Simon Glass,
> >
> >> This commit broke USB2 on link (Chromebook Pixel):
> >> 020bbcb usb: hub: Power-cycle on root-hub ports
> >>
> >> However the root cause seems to be a missing mask and missing 'break'
> >> in ehci-hcd.c. This patch fixes both.
> >>
> >> On link, 'usb start' with a USB keyboard and memory stick inserted now
> >> finds both. The keyboard works as expected. Also ext2ls shows a
> >> directory listing from the memory stick.
> >>
> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> > Picking up all three, thanks!
>
> Thanks, also Julius may have some comments on Monday. Two of the
> patches were reviewed by him, but not the last one, although he
> suggested it.
I just build-tested them, seem OK.
btw. I might be less available this month, sorry about that.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-05-11 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 2:48 [U-Boot] [PATCH 1/3] usb: properly re-initialize the USB keyboard Simon Glass
2013-05-11 2:48 ` [U-Boot] [PATCH 2/3] usb: workaround non-working keyboards Simon Glass
2013-05-11 2:49 ` [U-Boot] [PATCH 3/3] usb: Correct CLEAR_FEATURE code in ehci-hcd Simon Glass
2013-05-11 16:39 ` Marek Vasut
2013-05-11 17:27 ` Simon Glass
2013-05-11 17:59 ` Marek Vasut [this message]
2013-05-13 18:19 ` Julius Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305111959.38111.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox