public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] avr32: fix relocation address calculation
Date: Mon, 13 May 2013 13:43:22 +0200	[thread overview]
Message-ID: <20130513134322.2d7dc119@lilith> (raw)
In-Reply-To: <20130510112444.4dca773f@lilith>

On Fri, 10 May 2013 11:24:44 +0200, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:

> Sorry for not spotting this before it was merged in; but now this must
> be fixed. I'm ok with the wrongly-ulong symbols being changed back to
> char[], though I would prefer their type to be char[0] if possible, as
> this is (admittedly marginally) more likely to help the compiler catch
> accidental dereferencings.

Following the latest exchange with Andreas, and after some tests with
eldk42 and a gcc 4.7 toolchain, I amend the previous paragraph: rather
than 'char[0]', I suggest using 'struct {}'.

Amicalement,
-- 
Albert.

  parent reply	other threads:[~2013-05-13 11:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08  9:25 [U-Boot] [PATCH] avr32: fix relocation address calculation Andreas Bießmann
2013-05-10  9:24 ` Albert ARIBAUD
2013-05-10 10:57   ` Andreas Bießmann
2013-05-10 15:09     ` Albert ARIBAUD
2013-05-10 17:02       ` Michael Cashwell
2013-05-10 17:15         ` Albert ARIBAUD
2013-05-13  8:35       ` Andreas Bießmann
2013-05-13 11:34         ` Albert ARIBAUD
2013-05-13 11:43   ` Albert ARIBAUD [this message]
2013-05-13  8:38 ` [U-Boot] " Andreas Bießmann
2013-05-13  8:42   ` Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130513134322.2d7dc119@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox