public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add minimal support for Congatec Conga-QEVAl Evaluation Carrier Board with a conga-Qmx6 module.
Date: Tue, 14 May 2013 00:32:31 +0200	[thread overview]
Message-ID: <20130513223231.43C203804AF@gemini.denx.de> (raw)
In-Reply-To: <3465D313FDFB824F9A9C8CD24FA4F6BC0108CCF5@frontmail.adetel.com>

Dear "SARTRE Leo",

In message <3465D313FDFB824F9A9C8CD24FA4F6BC0108CCF5@frontmail.adetel.com> you wrote:
>
> I will rework my patch taking all your remarks, and those from Wolfgang, into 
> acount, I just like to talk a bit about the problem of duplicated code that 
> you spooted. 
> This patch is just a first commit for this board, there will come other commits 
> to add missing functionnalities provided by the board, so I think that it will 
> be more convenient to have a separate file even if for now, it is very similar 
> to the sabrelite file. 

NAK.  Duplicating code is NEVER a good idea.  Even if you want to add
other / more stuff, then it makes a lot of sense to factor out the
common parts into a common file.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The human race is a race of cowards; and I am not  only  marching  in
that procession but carrying a banner.                   - Mark Twain

  reply	other threads:[~2013-05-13 22:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1368446578-13390-1-git-send-email-lsartre@adeneo-embedded.com>
2013-05-13 12:02 ` [U-Boot] [PATCH] Add minimal support for Congatec Conga-QEVAl Evaluation Carrier Board with a conga-Qmx6 module SARTRE Leo
2013-05-13 12:58   ` Stefano Babic
2013-05-13 15:09     ` SARTRE Leo
2013-05-13 22:32       ` Wolfgang Denk [this message]
2013-05-13 15:03   ` Eric Bénard
2013-05-13 12:02 ` [U-Boot] [PATCH 2/2] Add instruction file (based on the README for the sabrelite) for booting the Congatec board from SD-Card SARTRE Leo
2013-05-13 13:00   ` Wolfgang Denk
2013-05-13 13:02   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130513223231.43C203804AF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox