From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 14 May 2013 00:32:31 +0200 Subject: [U-Boot] [PATCH] Add minimal support for Congatec Conga-QEVAl Evaluation Carrier Board with a conga-Qmx6 module. In-Reply-To: <3465D313FDFB824F9A9C8CD24FA4F6BC0108CCF5@frontmail.adetel.com> References: <1368446578-13390-1-git-send-email-lsartre@adeneo-embedded.com> <3465D313FDFB824F9A9C8CD24FA4F6BC0108CCF3@frontmail.adetel.com> <5190E378.3060607@denx.de> <3465D313FDFB824F9A9C8CD24FA4F6BC0108CCF5@frontmail.adetel.com> Message-ID: <20130513223231.43C203804AF@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear "SARTRE Leo", In message <3465D313FDFB824F9A9C8CD24FA4F6BC0108CCF5@frontmail.adetel.com> you wrote: > > I will rework my patch taking all your remarks, and those from Wolfgang, into > acount, I just like to talk a bit about the problem of duplicated code that > you spooted. > This patch is just a first commit for this board, there will come other commits > to add missing functionnalities provided by the board, so I think that it will > be more convenient to have a separate file even if for now, it is very similar > to the sabrelite file. NAK. Duplicating code is NEVER a good idea. Even if you want to add other / more stuff, then it makes a lot of sense to factor out the common parts into a common file. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The human race is a race of cowards; and I am not only marching in that procession but carrying a banner. - Mark Twain