public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: asix: Move software resets to basic_init
Date: Tue, 14 May 2013 00:10:31 +0200	[thread overview]
Message-ID: <201305140010.31343.marex@denx.de> (raw)
In-Reply-To: <CANr=Z=Zb2B0N56aiSJL84oRegwa2UG3wnvsRvyNSVQpe6J=RjA@mail.gmail.com>

Dear Joe Hershberger,

> On Mon, May 13, 2013 at 10:14 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Simon Glass,
> > 
> >> From: Julius Werner <jwerner@chromium.org>
> >> 
> >> The ASIX driver calls a basic_init() function during get_info(), so that
> >> not all initialization tasks need to be redone on every init().
> >> Unfortunately, the most important one is still triggered too often: the
> >> driver does a full port and MII reset on every asix_init(), requiring up
> >> to several seconds to reestablish the link.
> >> 
> >> This patch confines that software reset into the asix_basic_init()
> >> function so that it will only be executed once. This saves about a
> >> second of boot time on systems using BOOTP.
> >> 
> >> Note: this patch was previously submitted many moons ago as:
> >>    usb: usbeth: asix: Do a fast init if link already established
> >> 
> >> That patch seens to have been lost or forgotten, so this is a rebased
> >> version. It is tested on snow with a Asix USB dongle (Cisco).
> >> 
> >> Signed-off-by: Julius Werner <jwerner@chromium.org>
> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >> Reviewed-by: Simon Glass <sjg@chromium.org>
> >> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
> > 
> > I'll pick it, but I wonder why Joe didn't ...
> 
> Sorry... just swamped for the moment.

Same here :-/

Best regards,
Marek Vasut

      reply	other threads:[~2013-05-13 22:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-11 20:35 [U-Boot] [PATCH] usb: asix: Move software resets to basic_init Simon Glass
2013-05-13 15:14 ` Marek Vasut
2013-05-13 21:30   ` Joe Hershberger
2013-05-13 22:10     ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305140010.31343.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox