From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 14 May 2013 00:10:31 +0200 Subject: [U-Boot] [PATCH] usb: asix: Move software resets to basic_init In-Reply-To: References: <1368304502-18555-1-git-send-email-sjg@chromium.org> <201305131714.26750.marex@denx.de> Message-ID: <201305140010.31343.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Joe Hershberger, > On Mon, May 13, 2013 at 10:14 AM, Marek Vasut wrote: > > Dear Simon Glass, > > > >> From: Julius Werner > >> > >> The ASIX driver calls a basic_init() function during get_info(), so that > >> not all initialization tasks need to be redone on every init(). > >> Unfortunately, the most important one is still triggered too often: the > >> driver does a full port and MII reset on every asix_init(), requiring up > >> to several seconds to reestablish the link. > >> > >> This patch confines that software reset into the asix_basic_init() > >> function so that it will only be executed once. This saves about a > >> second of boot time on systems using BOOTP. > >> > >> Note: this patch was previously submitted many moons ago as: > >> usb: usbeth: asix: Do a fast init if link already established > >> > >> That patch seens to have been lost or forgotten, so this is a rebased > >> version. It is tested on snow with a Asix USB dongle (Cisco). > >> > >> Signed-off-by: Julius Werner > >> Signed-off-by: Simon Glass > >> Reviewed-by: Simon Glass > >> Reviewed-by: Vadim Bendebury > > > > I'll pick it, but I wonder why Joe didn't ... > > Sorry... just swamped for the moment. Same here :-/ Best regards, Marek Vasut