From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 14 May 2013 11:31:19 -0400 Subject: [U-Boot] fatwrite problem In-Reply-To: <15AE5A936F5E3A42A9144E66875A0A89308F00@server1-derijp.CLB-Benelux.lokaal> References: <15AE5A936F5E3A42A9144E66875A0A89308BCA@server1-derijp.CLB-Benelux.lokaal> <15AE5A936F5E3A42A9144E66875A0A89308BD0@server1-derijp.CLB-Benelux.lokaal> <20130412151231.GP9914@bill-the-cat> <807994631.1713509.1365795559751.JavaMail.root@advansee.com> <20130412204234.GV9914@bill-the-cat> <703914118.1714507.1365801468095.JavaMail.root@advansee.com> <15AE5A936F5E3A42A9144E66875A0A89308F00@server1-derijp.CLB-Benelux.lokaal> Message-ID: <20130514153119.GO29196@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, May 14, 2013 at 05:13:44PM +0200, Ruud Commandeur wrote: > Hi Tom, > > It has become a bit quiet on this thread, but I just made the changes as I suggested, including some other fixes. Here is what I did: > > > Added a check for blkcnt > 0 in mmc_write_blocks (drivers/mmc.c). By doing this in the lowest level function, it also solves a hangup if for instance an "mmc write" command is given with a block count being 0. > > > Solved a checksum issue in fs/fat/fat.c. The mkcksum has const char arguments with a size specifier, like "const char name[8]". In the function, it is assumed that sizeof(name) will have the value 8, but this is not the case (at least not for the compiler I use and I guess not according to ANSI C). This causes "long filename checksum errors" for each fat file listed or written. > > > Made some changes to fs/fat/fat_write.c. Fixed testing fat_val for 0xffff/0xfff8 and 0xfffffff/0xffffff8 by adding the corresponding fatsize in the test (as I read in earlier posts) and some changes in debug output. > > I have used this for a few weeks now without any mmc and fat related problems sofar. > > I do have a patch file for this. Should I post this with a "Signed-off-by (etc, etc)", or would you like to receive and review this patch file yourself first? Please post it with a Signed-off-by line for review on the list, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: