public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit
Date: Wed, 15 May 2013 05:36:14 +0200	[thread overview]
Message-ID: <201305150536.14239.marex@denx.de> (raw)
In-Reply-To: <1368587097.8322.2.camel@phoenix>

Dear Axel Lin,

> cpu_init_crit() can be skipped, but the code is still enabled requiring a
> platform to supply lowlevel_init().
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Nice CC list, it'd be the best if you CCed the ARM maintainer too though ;-)

> ---
>  arch/arm/cpu/arm720t/start.S | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S
> index 9facc7e..9f0e3f9 100644
> --- a/arch/arm/cpu/arm720t/start.S
> +++ b/arch/arm/cpu/arm720t/start.S
> @@ -244,6 +244,7 @@ c_runtime_cpu_setup:
>   *************************************************************************
>   */
> 
> +#ifndef CONFIG_SKIP_LOWLEVEL_INIT
>  cpu_init_crit:
> 
>  #if !defined(CONFIG_TEGRA)
> @@ -258,6 +259,7 @@ cpu_init_crit:
>  #endif
> 
>  	mov	pc, lr
> +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
> 
> 
>  #ifndef CONFIG_SPL_BUILD

Best regards,
Marek Vasut

  reply	other threads:[~2013-05-15  3:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15  3:04 [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit Axel Lin
2013-05-15  3:36 ` Marek Vasut [this message]
2013-05-15 13:10   ` Albert ARIBAUD
2013-05-16  0:40     ` Axel Lin
2013-05-15 14:32 ` Stephen Warren
2013-05-16  1:00   ` Axel Lin
2013-05-16  4:28     ` Stephen Warren
2013-05-17 22:11       ` Tom Warren
2013-05-18 18:57         ` Albert ARIBAUD
2013-05-21 17:51           ` Tom Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305150536.14239.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox