From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Wed, 15 May 2013 09:46:17 +0200
Subject: [U-Boot] [PATCH 4/5] arm: ensure u-boot only uses relative
	relocations
In-Reply-To: <513800182.822768.1368569544454.JavaMail.root@advansee.com>
References: <1368561780-19104-1-git-send-email-albert.u.boot@aribaud.net>
	<1368561780-19104-2-git-send-email-albert.u.boot@aribaud.net>
	<1368561780-19104-3-git-send-email-albert.u.boot@aribaud.net>
	<1368561780-19104-4-git-send-email-albert.u.boot@aribaud.net>
	<1368561780-19104-5-git-send-email-albert.u.boot@aribaud.net>
	<513800182.822768.1368569544454.JavaMail.root@advansee.com>
Message-ID: <20130515094617.5d79dca9@lilith>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Beno?t,

On Wed, 15 May 2013 00:12:24 +0200 (CEST), Beno?t Th?baudeau
<benoit.thebaudeau@advansee.com> wrote:

> Hi Albert,

> > --- a/Makefile
> > +++ b/Makefile
> > @@ -746,6 +746,13 @@ tools: $(VERSION_FILE) $(TIMESTAMP_FILE)
> >  	$(MAKE) -C $@ all
> >  endif	# config.mk
> >  
> > +# ARM relocations should all be R_ARM_RELATIVE.
> > +checkarmreloc: $(obj)u-boot
> > +	@if test "R_ARM_RELATIVE" != \
> > +		"`readelf -r $(obj)u-boot | cut -d ' ' -f 4 | grep R_ARM | sort -u`"; \
>                              ^
>                              or $$< to avoid a duplicate?

Will fix as suggested.

> > +		then echo "$(obj)u-boot contains relocations other than \
>                            ^
>                            or $$< too, or no $(obj) prefix@all for this message?

I prefer leaving the prefix so that failures during out-of-tree builds
or during MAKEALL builds with BUILD_NBUILDS>1 log the correct path.

> Best regards,
> Beno?t

Thanks!

Amicalement,
-- 
Albert.