* [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit @ 2013-05-15 3:04 Axel Lin 2013-05-15 3:36 ` Marek Vasut 2013-05-15 14:32 ` Stephen Warren 0 siblings, 2 replies; 10+ messages in thread From: Axel Lin @ 2013-05-15 3:04 UTC (permalink / raw) To: u-boot cpu_init_crit() can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init(). Signed-off-by: Axel Lin <axel.lin@ingics.com> --- arch/arm/cpu/arm720t/start.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S index 9facc7e..9f0e3f9 100644 --- a/arch/arm/cpu/arm720t/start.S +++ b/arch/arm/cpu/arm720t/start.S @@ -244,6 +244,7 @@ c_runtime_cpu_setup: ************************************************************************* */ +#ifndef CONFIG_SKIP_LOWLEVEL_INIT cpu_init_crit: #if !defined(CONFIG_TEGRA) @@ -258,6 +259,7 @@ cpu_init_crit: #endif mov pc, lr +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */ #ifndef CONFIG_SPL_BUILD -- 1.8.1.2 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit 2013-05-15 3:04 [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit Axel Lin @ 2013-05-15 3:36 ` Marek Vasut 2013-05-15 13:10 ` Albert ARIBAUD 2013-05-15 14:32 ` Stephen Warren 1 sibling, 1 reply; 10+ messages in thread From: Marek Vasut @ 2013-05-15 3:36 UTC (permalink / raw) To: u-boot Dear Axel Lin, > cpu_init_crit() can be skipped, but the code is still enabled requiring a > platform to supply lowlevel_init(). > > Signed-off-by: Axel Lin <axel.lin@ingics.com> Nice CC list, it'd be the best if you CCed the ARM maintainer too though ;-) > --- > arch/arm/cpu/arm720t/start.S | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S > index 9facc7e..9f0e3f9 100644 > --- a/arch/arm/cpu/arm720t/start.S > +++ b/arch/arm/cpu/arm720t/start.S > @@ -244,6 +244,7 @@ c_runtime_cpu_setup: > ************************************************************************* > */ > > +#ifndef CONFIG_SKIP_LOWLEVEL_INIT > cpu_init_crit: > > #if !defined(CONFIG_TEGRA) > @@ -258,6 +259,7 @@ cpu_init_crit: > #endif > > mov pc, lr > +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */ > > > #ifndef CONFIG_SPL_BUILD Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit 2013-05-15 3:36 ` Marek Vasut @ 2013-05-15 13:10 ` Albert ARIBAUD 2013-05-16 0:40 ` Axel Lin 0 siblings, 1 reply; 10+ messages in thread From: Albert ARIBAUD @ 2013-05-15 13:10 UTC (permalink / raw) To: u-boot Hi Marek, On Wed, 15 May 2013 05:36:14 +0200, Marek Vasut <marex@denx.de> wrote: > Dear Axel Lin, > > > cpu_init_crit() can be skipped, but the code is still enabled requiring a > > platform to supply lowlevel_init(). > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > > Nice CC list, it'd be the best if you CCed the ARM maintainer too though ;-) Thanks Marek. :) > > --- > > arch/arm/cpu/arm720t/start.S | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S > > index 9facc7e..9f0e3f9 100644 > > --- a/arch/arm/cpu/arm720t/start.S > > +++ b/arch/arm/cpu/arm720t/start.S > > @@ -244,6 +244,7 @@ c_runtime_cpu_setup: > > ************************************************************************* > > */ > > > > +#ifndef CONFIG_SKIP_LOWLEVEL_INIT > > cpu_init_crit: > > > > #if !defined(CONFIG_TEGRA) > > @@ -258,6 +259,7 @@ cpu_init_crit: > > #endif > > > > mov pc, lr > > +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */ > > > > > > #ifndef CONFIG_SPL_BUILD I am tempted to ask: what actual issue does this guarding aim at solving? Just in case, beware that AFAIR Wolfgang does not consider 'because debugging' a valid answer. > Best regards, > Marek Vasut Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit 2013-05-15 13:10 ` Albert ARIBAUD @ 2013-05-16 0:40 ` Axel Lin 0 siblings, 0 replies; 10+ messages in thread From: Axel Lin @ 2013-05-16 0:40 UTC (permalink / raw) To: u-boot 2013/5/15 Albert ARIBAUD <albert.u.boot@aribaud.net>: > Hi Marek, > > On Wed, 15 May 2013 05:36:14 +0200, Marek Vasut <marex@denx.de> wrote: > >> Dear Axel Lin, >> >> > cpu_init_crit() can be skipped, but the code is still enabled requiring a >> > platform to supply lowlevel_init(). >> > >> > Signed-off-by: Axel Lin <axel.lin@ingics.com> >> >> Nice CC list, it'd be the best if you CCed the ARM maintainer too though ;-) > > Thanks Marek. :) > >> > --- >> > arch/arm/cpu/arm720t/start.S | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S >> > index 9facc7e..9f0e3f9 100644 >> > --- a/arch/arm/cpu/arm720t/start.S >> > +++ b/arch/arm/cpu/arm720t/start.S >> > @@ -244,6 +244,7 @@ c_runtime_cpu_setup: >> > ************************************************************************* >> > */ >> > >> > +#ifndef CONFIG_SKIP_LOWLEVEL_INIT >> > cpu_init_crit: >> > >> > #if !defined(CONFIG_TEGRA) >> > @@ -258,6 +259,7 @@ cpu_init_crit: >> > #endif >> > >> > mov pc, lr >> > +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */ >> > >> > >> > #ifndef CONFIG_SPL_BUILD > > I am tempted to ask: what actual issue does this guarding aim at > solving? Just in case, beware that AFAIR Wolfgang does not consider > 'because debugging' a valid answer. This fixes below build error if a platform has set CONFIG_SKIP_LOWLEVEL_INIT but does not implement lowlevel_init. arch/arm/cpu/arm720t/start.o: In function `cpu_init_crit': arch/arm/cpu/arm720t/start.S:256: undefined reference to `lowlevel_init' I have no idea if current supported boards in u-boot has this issue or not. I hit this build error because I'm porting u-boot to a SoC that is not supported by u-boot at this moment. Regards, Axel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit 2013-05-15 3:04 [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit Axel Lin 2013-05-15 3:36 ` Marek Vasut @ 2013-05-15 14:32 ` Stephen Warren 2013-05-16 1:00 ` Axel Lin 1 sibling, 1 reply; 10+ messages in thread From: Stephen Warren @ 2013-05-15 14:32 UTC (permalink / raw) To: u-boot On 05/14/2013 09:04 PM, Axel Lin wrote: > cpu_init_crit() can be skipped, but the code is still enabled requiring a > platform to supply lowlevel_init(). > diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S > +#ifndef CONFIG_SKIP_LOWLEVEL_INIT > cpu_init_crit: > > #if !defined(CONFIG_TEGRA) > @@ -258,6 +259,7 @@ cpu_init_crit: > #endif > > mov pc, lr > +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */ If you're going to make changes here, you should probably ensure that Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the Tegra-specific ifdef from the body of that function. That's assuming that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side-effects. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit 2013-05-15 14:32 ` Stephen Warren @ 2013-05-16 1:00 ` Axel Lin 2013-05-16 4:28 ` Stephen Warren 0 siblings, 1 reply; 10+ messages in thread From: Axel Lin @ 2013-05-16 1:00 UTC (permalink / raw) To: u-boot 2013/5/15 Stephen Warren <swarren@wwwdotorg.org>: > On 05/14/2013 09:04 PM, Axel Lin wrote: >> cpu_init_crit() can be skipped, but the code is still enabled requiring a >> platform to supply lowlevel_init(). > >> diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S > >> +#ifndef CONFIG_SKIP_LOWLEVEL_INIT >> cpu_init_crit: >> >> #if !defined(CONFIG_TEGRA) >> @@ -258,6 +259,7 @@ cpu_init_crit: >> #endif >> >> mov pc, lr >> +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */ > > If you're going to make changes here, you should probably ensure that > Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the > Tegra-specific ifdef from the body of that function. That's assuming > that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side-effects. Tegra exists in both arm720t and armv7: ./arch/arm/cpu/arm720t/tegra-common ./arch/arm/cpu/arm720t/tegra30 ./arch/arm/cpu/arm720t/tegra20 ./arch/arm/cpu/arm720t/tegra114 ./arch/arm/cpu/armv7/tegra-common ./arch/arm/cpu/armv7/tegra30 ./arch/arm/cpu/armv7/tegra20 ./arch/arm/cpu/armv7/tegra114 I'm wondering if we set CONFIG_SKIP_LOWLEVEL_INIT for tegra will also impact the code path in arch/arm/cpu/armv7/start.S ? Regards, Axel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit 2013-05-16 1:00 ` Axel Lin @ 2013-05-16 4:28 ` Stephen Warren 2013-05-17 22:11 ` Tom Warren 0 siblings, 1 reply; 10+ messages in thread From: Stephen Warren @ 2013-05-16 4:28 UTC (permalink / raw) To: u-boot On 05/15/2013 07:00 PM, Axel Lin wrote: > 2013/5/15 Stephen Warren <swarren@wwwdotorg.org>: >> On 05/14/2013 09:04 PM, Axel Lin wrote: >>> cpu_init_crit() can be skipped, but the code is still enabled requiring a >>> platform to supply lowlevel_init(). >> >>> diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S >> >>> +#ifndef CONFIG_SKIP_LOWLEVEL_INIT >>> cpu_init_crit: >>> >>> #if !defined(CONFIG_TEGRA) >>> @@ -258,6 +259,7 @@ cpu_init_crit: >>> #endif >>> >>> mov pc, lr >>> +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */ >> >> If you're going to make changes here, you should probably ensure that >> Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the >> Tegra-specific ifdef from the body of that function. That's assuming >> that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side-effects. > > Tegra exists in both arm720t and armv7: > > ./arch/arm/cpu/arm720t/tegra-common > ./arch/arm/cpu/arm720t/tegra30 > ./arch/arm/cpu/arm720t/tegra20 > ./arch/arm/cpu/arm720t/tegra114 > > ./arch/arm/cpu/armv7/tegra-common > ./arch/arm/cpu/armv7/tegra30 > ./arch/arm/cpu/armv7/tegra20 > ./arch/arm/cpu/armv7/tegra114 > > I'm wondering if we set CONFIG_SKIP_LOWLEVEL_INIT for tegra will also > impact the code path in arch/arm/cpu/armv7/start.S ? Yes, you certainly only want to set CONFIG_SKIP_LOWLEVEL_INIT for the SPL build. There's a whole section of include/configs/tegra-common-post.h which is ifdef CONFIG_SPL_BUILD, so it might make sense to #define CONFIG_SKIP_LOWLEVEL_INIT there. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit 2013-05-16 4:28 ` Stephen Warren @ 2013-05-17 22:11 ` Tom Warren 2013-05-18 18:57 ` Albert ARIBAUD 0 siblings, 1 reply; 10+ messages in thread From: Tom Warren @ 2013-05-17 22:11 UTC (permalink / raw) To: u-boot Axel (& Albert) > -----Original Message----- > From: Stephen Warren [mailto:swarren at wwwdotorg.org] > Sent: Wednesday, May 15, 2013 9:29 PM > To: Axel Lin > Cc: Wolfgang Denk; Heiko Schocher; Tom Warren; u-boot at lists.denx.de > Subject: Re: [U-Boot] [PATCH] ARM: arm720t: Add missing > CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit > > On 05/15/2013 07:00 PM, Axel Lin wrote: > > 2013/5/15 Stephen Warren <swarren@wwwdotorg.org>: > >> On 05/14/2013 09:04 PM, Axel Lin wrote: > >>> cpu_init_crit() can be skipped, but the code is still enabled > >>> requiring a platform to supply lowlevel_init(). > >> > >>> diff --git a/arch/arm/cpu/arm720t/start.S > >>> b/arch/arm/cpu/arm720t/start.S > >> > >>> +#ifndef CONFIG_SKIP_LOWLEVEL_INIT > >>> cpu_init_crit: > >>> > >>> #if !defined(CONFIG_TEGRA) > >>> @@ -258,6 +259,7 @@ cpu_init_crit: > >>> #endif > >>> > >>> mov pc, lr > >>> +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */ > >> > >> If you're going to make changes here, you should probably ensure that > >> Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the > >> Tegra-specific ifdef from the body of that function. That's assuming > >> that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side- > effects. > > > > Tegra exists in both arm720t and armv7: > > > > ./arch/arm/cpu/arm720t/tegra-common > > ./arch/arm/cpu/arm720t/tegra30 > > ./arch/arm/cpu/arm720t/tegra20 > > ./arch/arm/cpu/arm720t/tegra114 > > > > ./arch/arm/cpu/armv7/tegra-common > > ./arch/arm/cpu/armv7/tegra30 > > ./arch/arm/cpu/armv7/tegra20 > > ./arch/arm/cpu/armv7/tegra114 > > > > I'm wondering if we set CONFIG_SKIP_LOWLEVEL_INIT for tegra will also > > impact the code path in arch/arm/cpu/armv7/start.S ? > > Yes, you certainly only want to set CONFIG_SKIP_LOWLEVEL_INIT for the SPL > build. There's a whole section of include/configs/tegra-common-post.h > which is ifdef CONFIG_SPL_BUILD, so it might make sense to #define > CONFIG_SKIP_LOWLEVEL_INIT there. I've applied your two patches (this one and the RFT for Tegra) to u-boot-tegra/next and I'm running a MAKEALL right now, then I'll do a test on Cardhu and Dalmore. Both of these are assigned to me in PatchWork - Albert - do you want me to take them both in via the Tegra tree, or do you want to take the ARM patch and I'll take the Tegra patch? Let me know. Axel - I'll let you know how testing goes, and then you can resubmit the RFT patch as a real patch against Tegra. Thanks, Tom -- nvpublic ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit 2013-05-17 22:11 ` Tom Warren @ 2013-05-18 18:57 ` Albert ARIBAUD 2013-05-21 17:51 ` Tom Warren 0 siblings, 1 reply; 10+ messages in thread From: Albert ARIBAUD @ 2013-05-18 18:57 UTC (permalink / raw) To: u-boot Hi Tom, On Fri, 17 May 2013 15:11:26 -0700, Tom Warren <TWarren@nvidia.com> wrote: > Axel (& Albert) > > > -----Original Message----- > > From: Stephen Warren [mailto:swarren at wwwdotorg.org] > > Sent: Wednesday, May 15, 2013 9:29 PM > > To: Axel Lin > > Cc: Wolfgang Denk; Heiko Schocher; Tom Warren; u-boot at lists.denx.de > > Subject: Re: [U-Boot] [PATCH] ARM: arm720t: Add missing > > CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit > > > > On 05/15/2013 07:00 PM, Axel Lin wrote: > > > 2013/5/15 Stephen Warren <swarren@wwwdotorg.org>: > > >> On 05/14/2013 09:04 PM, Axel Lin wrote: > > >>> cpu_init_crit() can be skipped, but the code is still enabled > > >>> requiring a platform to supply lowlevel_init(). > > >> > > >>> diff --git a/arch/arm/cpu/arm720t/start.S > > >>> b/arch/arm/cpu/arm720t/start.S > > >> > > >>> +#ifndef CONFIG_SKIP_LOWLEVEL_INIT > > >>> cpu_init_crit: > > >>> > > >>> #if !defined(CONFIG_TEGRA) > > >>> @@ -258,6 +259,7 @@ cpu_init_crit: > > >>> #endif > > >>> > > >>> mov pc, lr > > >>> +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */ > > >> > > >> If you're going to make changes here, you should probably ensure that > > >> Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the > > >> Tegra-specific ifdef from the body of that function. That's assuming > > >> that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side- > > effects. > > > > > > Tegra exists in both arm720t and armv7: > > > > > > ./arch/arm/cpu/arm720t/tegra-common > > > ./arch/arm/cpu/arm720t/tegra30 > > > ./arch/arm/cpu/arm720t/tegra20 > > > ./arch/arm/cpu/arm720t/tegra114 > > > > > > ./arch/arm/cpu/armv7/tegra-common > > > ./arch/arm/cpu/armv7/tegra30 > > > ./arch/arm/cpu/armv7/tegra20 > > > ./arch/arm/cpu/armv7/tegra114 > > > > > > I'm wondering if we set CONFIG_SKIP_LOWLEVEL_INIT for tegra will also > > > impact the code path in arch/arm/cpu/armv7/start.S ? > > > > Yes, you certainly only want to set CONFIG_SKIP_LOWLEVEL_INIT for the SPL > > build. There's a whole section of include/configs/tegra-common-post.h > > which is ifdef CONFIG_SPL_BUILD, so it might make sense to #define > > CONFIG_SKIP_LOWLEVEL_INIT there. > I've applied your two patches (this one and the RFT for Tegra) to u-boot-tegra/next and I'm running a MAKEALL right now, then I'll do a test on Cardhu and Dalmore. > > Both of these are assigned to me in PatchWork - Albert - do you want me to take them both in via the Tegra tree, or do you want to take the ARM patch and I'll take the Tegra patch? Let me know. Please take both in Tegra tree. > Axel - I'll let you know how testing goes, and then you can resubmit the RFT patch as a real patch against Tegra. > > Thanks, > > Tom > -- > nvpublic Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit 2013-05-18 18:57 ` Albert ARIBAUD @ 2013-05-21 17:51 ` Tom Warren 0 siblings, 0 replies; 10+ messages in thread From: Tom Warren @ 2013-05-21 17:51 UTC (permalink / raw) To: u-boot Albert (& Axel), > -----Original Message----- > From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net] > Sent: Saturday, May 18, 2013 11:58 AM > To: Tom Warren > Cc: Stephen Warren; Axel Lin; Wolfgang Denk; Heiko Schocher; u- > boot at lists.denx.de > Subject: Re: [U-Boot] [PATCH] ARM: arm720t: Add missing > CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit > > Hi Tom, > > On Fri, 17 May 2013 15:11:26 -0700, Tom Warren <TWarren@nvidia.com> > wrote: > > > Axel (& Albert) > > > > > -----Original Message----- > > > From: Stephen Warren [mailto:swarren at wwwdotorg.org] > > > Sent: Wednesday, May 15, 2013 9:29 PM > > > To: Axel Lin > > > Cc: Wolfgang Denk; Heiko Schocher; Tom Warren; u-boot at lists.denx.de > > > Subject: Re: [U-Boot] [PATCH] ARM: arm720t: Add missing > > > CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit > > > > > > On 05/15/2013 07:00 PM, Axel Lin wrote: > > > > 2013/5/15 Stephen Warren <swarren@wwwdotorg.org>: > > > >> On 05/14/2013 09:04 PM, Axel Lin wrote: > > > >>> cpu_init_crit() can be skipped, but the code is still enabled > > > >>> requiring a platform to supply lowlevel_init(). > > > >> > > > >>> diff --git a/arch/arm/cpu/arm720t/start.S > > > >>> b/arch/arm/cpu/arm720t/start.S > > > >> > > > >>> +#ifndef CONFIG_SKIP_LOWLEVEL_INIT > > > >>> cpu_init_crit: > > > >>> > > > >>> #if !defined(CONFIG_TEGRA) > > > >>> @@ -258,6 +259,7 @@ cpu_init_crit: > > > >>> #endif > > > >>> > > > >>> mov pc, lr > > > >>> +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */ > > > >> > > > >> If you're going to make changes here, you should probably ensure > > > >> that Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove > > > >> the Tegra-specific ifdef from the body of that function. That's > > > >> assuming that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any > > > >> other side- > > > effects. > > > > > > > > Tegra exists in both arm720t and armv7: > > > > > > > > ./arch/arm/cpu/arm720t/tegra-common > > > > ./arch/arm/cpu/arm720t/tegra30 > > > > ./arch/arm/cpu/arm720t/tegra20 > > > > ./arch/arm/cpu/arm720t/tegra114 > > > > > > > > ./arch/arm/cpu/armv7/tegra-common > > > > ./arch/arm/cpu/armv7/tegra30 > > > > ./arch/arm/cpu/armv7/tegra20 > > > > ./arch/arm/cpu/armv7/tegra114 > > > > > > > > I'm wondering if we set CONFIG_SKIP_LOWLEVEL_INIT for tegra will > > > > also impact the code path in arch/arm/cpu/armv7/start.S ? > > > > > > Yes, you certainly only want to set CONFIG_SKIP_LOWLEVEL_INIT for > > > the SPL build. There's a whole section of > > > include/configs/tegra-common-post.h > > > which is ifdef CONFIG_SPL_BUILD, so it might make sense to #define > > > CONFIG_SKIP_LOWLEVEL_INIT there. > > I've applied your two patches (this one and the RFT for Tegra) to u-boot- > tegra/next and I'm running a MAKEALL right now, then I'll do a test on Cardhu > and Dalmore. > > > > Both of these are assigned to me in PatchWork - Albert - do you want me > to take them both in via the Tegra tree, or do you want to take the ARM > patch and I'll take the Tegra patch? Let me know. > > Please take both in Tegra tree. Will do. Axel - please resend these 2 patches w/o the RFT tag as a v2 and I'll take them in to the Tegra repo. Tom > > > Axel - I'll let you know how testing goes, and then you can resubmit the RFT > patch as a real patch against Tegra. > > > > Thanks, > > > > Tom > > -- > > nvpublic > > Amicalement, > -- > Albert. -- nvpublic ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-05-21 17:51 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-05-15 3:04 [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit Axel Lin 2013-05-15 3:36 ` Marek Vasut 2013-05-15 13:10 ` Albert ARIBAUD 2013-05-16 0:40 ` Axel Lin 2013-05-15 14:32 ` Stephen Warren 2013-05-16 1:00 ` Axel Lin 2013-05-16 4:28 ` Stephen Warren 2013-05-17 22:11 ` Tom Warren 2013-05-18 18:57 ` Albert ARIBAUD 2013-05-21 17:51 ` Tom Warren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox