From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add the symbol for the minimal SPL used to eliminate unused code
Date: Wed, 15 May 2013 19:58:44 -0400 [thread overview]
Message-ID: <20130515235844.GC32163@bill-the-cat> (raw)
In-Reply-To: <1368601339-8089-1-git-send-email-ying.zhang@freescale.com>
On Wed, May 15, 2013 at 03:02:19PM +0800, ying.zhang at freescale.com wrote:
> From: Ying Zhang <b40530@freescale.com>
>
> Add the symbol CONFIG_SPL_BUILD_MINIMAL for the minimal SPL. It used to
> eliminate code unused in the minimal SPL but used in the SPL.
[snip]
> diff --git a/common/env_common.c b/common/env_common.c
> index 906b41f..5d82ea0 100644
> --- a/common/env_common.c
> +++ b/common/env_common.c
> @@ -156,7 +156,7 @@ int set_default_vars(int nvars, char * const vars[])
> H_NOCLEAR | H_INTERACTIVE, nvars, vars);
> }
>
> -#ifndef CONFIG_SPL_BUILD
> +#ifndef CONFIG_SPL_BUILD_MINIMAL
> /*
> * Check if CRC is valid and (if yes) import the environment.
> * Note that "buf" may or may not be aligned.
Hold up, this ignores the whole world of CONFIG_SPL_FRAMEWORK and
probably breaks the ARM targets. You need to instal an ARM toolchain
(either one of the Linaro ones or ELDK 5.x) and make sure that MAKEALL
-a arm is also fine after your SPL changes.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130515/81664cf1/attachment.pgp>
next prev parent reply other threads:[~2013-05-15 23:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 7:02 [U-Boot] [PATCH] Add the symbol for the minimal SPL used to eliminate unused code ying.zhang at freescale.com
2013-05-15 22:45 ` Andy Fleming
2013-05-15 23:58 ` Tom Rini [this message]
2013-05-16 0:01 ` Scott Wood
2013-05-16 10:08 ` Zhang Ying-B40530
2013-05-16 12:36 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130515235844.GC32163@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox