From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Thu, 16 May 2013 18:57:19 +0200
Subject: [U-Boot] [PATCH v3 4/4] arm: factorize relocate_code routine
In-Reply-To: <2101738847.873216.1368719789615.JavaMail.root@advansee.com>
References: <1368525030-5162-1-git-send-email-albert.u.boot@aribaud.net>
	<1368705777-8789-1-git-send-email-albert.u.boot@aribaud.net>
	<1368705777-8789-2-git-send-email-albert.u.boot@aribaud.net>
	<1368705777-8789-3-git-send-email-albert.u.boot@aribaud.net>
	<1368705777-8789-4-git-send-email-albert.u.boot@aribaud.net>
	<1368705777-8789-5-git-send-email-albert.u.boot@aribaud.net>
	<2101738847.873216.1368719789615.JavaMail.root@advansee.com>
Message-ID: <20130516185719.4d24584a@lilith>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Beno?t,

On Thu, 16 May 2013 17:56:29 +0200 (CEST), Beno?t Th?baudeau
<benoit.thebaudeau@advansee.com> wrote:

> Hi Albert,

> Keeping an empty line here would be good for code clarity.

> Or "&_start" in the comment above to be more consistent with the comments below.

> It's __rel_dyn_start and __rel_dyn_end with 2 leading underscores in the 4
> comments above.

Will fix all three, thanks.

> Argh! The "bx lr" issue is back. That was correct in v2.

As you say: argh! Will fix, and apologies.

> The rest of the v3 series is fine.

Thanks for your review!

> Best regards,
> Beno?t

Amicalement,
-- 
Albert.