[U-Boot] [PULL] please pull u-boot-atmel/master

Andreas Bießmann
2012-11-06T09:19:21Z

Hi Albert,

On 05.11.2012 14:09, Albert ARIBAUD wrote:
> Hi Andreas,
>
> On Mon, 5 Nov 2012 11:19:30 +0100, Andreas Bie?mann
> <andreas.devel@googlemail.com> wrote:
>
>> Dear Albert Aribaud,
>>
>> The following changes since commit 46d626d3926cf6b9f9c477782c5a0ee620a424cd:
>>
>> socfpga/spl: Remove malloc.h (2012-11-04 16:23:23 +0100)
>>
>> are available in the git repository at:
>>
>> git://git.denx.de/u-boot-atmel.git master
>>
>> for you to fetch changes up to 15915a45d438b9e65e03c3052c3dbab1374927bc:
>>
>> at91: move get_chip_id() and get_extension_chip_id() to cpu.c, which can share with all at91 board. (2012-11-05 11:15:12 +0100)
>>
>> ----------------------------------------------------------------
>> Bo Shen (1):
>> video: atmel: implement lcd_setcolreg funtion
>
> What is the point of adding this function? This does not seem to be a
> strong override of a weak symbol, and therefore, it is dead code unless
> this patch is a dependency of one or several other patches -- in which
> case, please submit the other patch(es) along this one in your PR.

This one is required for http://patchwork.ozlabs.org/patch/196566/ and
was explicitly requested in a private mail to Bo to support for getting
the RFC working
(http://article.gmane.org/gmane.comp.boot-loaders.u-boot/145434). So you
are right here, currently it is dead code and could maybe added to a series.

On the other hand the lcd_setcolreg() is exported via include/lcd.h but
not provided by the atmel_hlcd driver which is an error.

>> Wu, Josh (1):
>> at91: move get_chip_id() and get_extension_chip_id() to cpu.c, which can share with all at91 board.
>
> This one, despite being a cleaner rewrite, also seems to be a
> preparatory patch waiting to be used.

Well, the get_*chip_id() are already used by some macros but only for a
single variant of at91. So you are right here when you call it
'preparatory', but it is not dead code as you may think.

> The whole PR is dead/dormant code. Please resubmit when dependent
> patches are added (or consider rolling back your master until you get
> these dependent patches).

However I rolled back the u-boot-atmel/master and will provide a series
for patch 1, patch 2 is so far NAKed until we get a user for that
reworked code.

Best regards

Andreas Bie?mann