[U-Boot] [PULL] please pull u-boot-atmel/master

Albert ARIBAUD
2012-11-05T13:09:52Z

Hi Andreas,

On Mon, 5 Nov 2012 11:19:30 +0100, Andreas Bie?mann
<andreas.devel@googlemail.com> wrote:

> Dear Albert Aribaud,
>
> The following changes since commit 46d626d3926cf6b9f9c477782c5a0ee620a424cd:
>
> socfpga/spl: Remove malloc.h (2012-11-04 16:23:23 +0100)
>
> are available in the git repository at:
>
> git://git.denx.de/u-boot-atmel.git master
>
> for you to fetch changes up to 15915a45d438b9e65e03c3052c3dbab1374927bc:
>
> at91: move get_chip_id() and get_extension_chip_id() to cpu.c, which can share with all at91 board. (2012-11-05 11:15:12 +0100)
>
> ----------------------------------------------------------------
> Bo Shen (1):
> video: atmel: implement lcd_setcolreg funtion

What is the point of adding this function? This does not seem to be a
strong override of a weak symbol, and therefore, it is dead code unless
this patch is a dependency of one or several other patches -- in which
case, please submit the other patch(es) along this one in your PR.

> Wu, Josh (1):
> at91: move get_chip_id() and get_extension_chip_id() to cpu.c, which can share with all at91 board.

This one, despite being a cleaner rewrite, also seems to be a
preparatory patch waiting to be used.

The whole PR is dead/dormant code. Please resubmit when dependent
patches are added (or consider rolling back your master until you get
these dependent patches).

Amicalement,
--
Albert.