public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] env_mmc: allow negative CONFIG_ENV_OFFSET
Date: Wed, 22 May 2013 11:46:58 -0400	[thread overview]
Message-ID: <20130522154658.GG10368@bill-the-cat> (raw)
In-Reply-To: <1369167921-11311-2-git-send-email-swarren@wwwdotorg.org>

On Tue, May 21, 2013 at 02:25:20PM -0600, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> A negative value of CONFIG_ENV_OFFSET is treated as a backwards offset
> from the end of the eMMC device/partition, rather than a forwards offset
> from the start.
> 
> This is useful when a single board may be stuffed with different eMMC
> devices, each of which has a different capacity, and you always want the
> environment to be stored at the very end of the device (or eMMC boot
> partition for example).
> 
> One example of this case is NVIDIA's Ventana reference board.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

NAK because you aren't also covering CONFIG_ENV_OFFSET_REDUND and you
need to update the README as it says ENV_OFFFSET is from the beginning
not end.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130522/9988cf6a/attachment.pgp>

  reply	other threads:[~2013-05-22 15:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 20:25 [U-Boot] [PATCH 1/3] mmc: report capacity for the selected partition Stephen Warren
2013-05-21 20:25 ` [U-Boot] [PATCH 2/3] env_mmc: allow negative CONFIG_ENV_OFFSET Stephen Warren
2013-05-22 15:46   ` Tom Rini [this message]
2013-05-22 16:00     ` Stephen Warren
2013-05-22 16:11       ` Tom Rini
2013-05-21 20:25 ` [U-Boot] [PATCH 3/3] ARM: tegra: make use of negative ENV_OFFSET on NVIDIA boards Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130522154658.GG10368@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox