public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/7] ahci: convert to use libata functions and definitions
Date: Fri, 24 May 2013 09:53:43 -0400	[thread overview]
Message-ID: <20130524135343.GL17119@bill-the-cat> (raw)
In-Reply-To: <1369176276-1895-7-git-send-email-robherring2@gmail.com>

On Tue, May 21, 2013 at 05:44:36PM -0500, Rob Herring wrote:

> From: Rob Herring <rob.herring@calxeda.com>
> 
> libata already has similar functions as implemented in the ahci code.
> Refactor the code to use the libata variants and remove the dependency on
> ata.h. Convert some defines to use the version from libata.h. Also, remove
> some unnecessary memset's of bss data.
> 
> This is a step toward hopefully merging ahci.c and dw_ahsata.c which are
> essentially the same driver.
> 
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>

Looks OK so:
Reviewed-by: Tom Rini <trini@ti.com>

But did you build coreboot/powerpc to make sure they still link fine at
least and we've got no new warnings?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130524/3ab2c655/attachment.pgp>

  reply	other threads:[~2013-05-24 13:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 22:44 [U-Boot] [PATCH 1/7] ahci: use ports implemented map instead of num_ports Rob Herring
2013-05-21 22:44 ` [U-Boot] [PATCH 2/7] ahci: fix unaligned access Rob Herring
2013-05-24 13:45   ` Tom Rini
2013-05-24 18:35   ` Wolfgang Denk
2013-05-21 22:44 ` [U-Boot] [PATCH 3/7] ahci: fix memory leak in ata_scsiop_inquiry Rob Herring
2013-05-24 13:46   ` Tom Rini
2013-05-21 22:44 ` [U-Boot] [PATCH 4/7] ahci: move link bring-up handling to separate function Rob Herring
2013-05-24 13:44   ` Tom Rini
2013-05-21 22:44 ` [U-Boot] [PATCH 5/7] ahci: handle COMINIT received during spin-up Rob Herring
2013-05-24 13:47   ` Tom Rini
2013-05-21 22:44 ` [U-Boot] [PATCH 6/7] ahci: increase spin-up timeout to 20 sec Rob Herring
2013-05-24 13:51   ` Tom Rini
2013-05-21 22:44 ` [U-Boot] [PATCH 7/7] ahci: convert to use libata functions and definitions Rob Herring
2013-05-24 13:53   ` Tom Rini [this message]
2013-05-24 13:45 ` [U-Boot] [PATCH 1/7] ahci: use ports implemented map instead of num_ports Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130524135343.GL17119@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox