From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/6] spl: Make CONFIG_SPL_BUILD contain more functionality
Date: Fri, 24 May 2013 12:11:01 -0400 [thread overview]
Message-ID: <20130524161101.GS17119@bill-the-cat> (raw)
In-Reply-To: <1369030048-26130-5-git-send-email-ying.zhang@freescale.com>
On Mon, May 20, 2013 at 02:07:27PM +0800, ying.zhang at freescale.com wrote:
> From: Ying Zhang <b40530@freescale.com>
>
> There was some functionality will be used in the SPL. They
> had been excluded by ifndef CONFIG_SPL_BUILD. Now, put it
> into the SPL.
>
> Signed-off-by: Ying Zhang <b40530@freescale.com>
> ---
> arch/powerpc/cpu/mpc85xx/tlb.c | 2 +-
> arch/powerpc/cpu/mpc8xxx/law.c | 4 ++--
In these cases can we not just always build them, aside from when
CONFIG_NAND_SPL is set and rely on link-time discard here? Otherwise:
> -#if !defined(CONFIG_NAND_SPL) && !defined(CONFIG_SPL_BUILD)
> +#if !defined(CONFIG_NAND_SPL) && !defined(CONFIG_SPL_NAND_MINIMAL)
Should become, I believe (and this isn't whitespaced properly):
#if !defined(CONFIG_NAND_SPL) && !(defined(CONFIG_SPL_BUILD) &&
defined(CONFIG_SPL_NAND_MINIMAL))
So that:
> diff --git a/include/configs/MPC8313ERDB.h b/include/configs/MPC8313ERDB.h
[snip]
> diff --git a/include/configs/P1022DS.h b/include/configs/P1022DS.h
[snip]
> diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs/p1_p2_rdb_pc.h
Can then all be dropped.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130524/54129188/attachment.pgp>
next prev parent reply other threads:[~2013-05-24 16:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 6:07 [U-Boot] [PATCH 1/6] powerpc/mpc85xx: support application without resetvec segment in the linker script ying.zhang at freescale.com
2013-05-20 6:07 ` [U-Boot] [PATCH 2/6] powerpc/mpc85xx: modify the functionality clear_bss and the end address of the BSS ying.zhang at freescale.com
2013-05-21 19:37 ` Scott Wood
2013-05-22 1:57 ` Zhang Ying-B40530
2013-05-20 6:07 ` [U-Boot] [PATCH 3/6] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT for environment in SPL ying.zhang at freescale.com
2013-05-23 15:36 ` Tom Rini
2013-06-21 20:47 ` [U-Boot] [U-Boot, " Andy Fleming
2013-05-20 6:07 ` [U-Boot] [PATCH 4/6] Makefile: move the common makefile line to public area ying.zhang at freescale.com
2013-05-24 16:04 ` Tom Rini
2013-06-06 8:51 ` Zhang Ying-B40530
2013-06-06 13:41 ` Tom Rini
2013-06-21 20:48 ` [U-Boot] [U-Boot, " Andy Fleming
2013-05-20 6:07 ` [U-Boot] [PATCH 5/6] spl: Make CONFIG_SPL_BUILD contain more functionality ying.zhang at freescale.com
2013-05-21 19:42 ` Scott Wood
2013-05-22 2:15 ` Zhang Ying-B40530
2013-05-22 15:45 ` Scott Wood
2013-05-23 1:26 ` Zhang Ying-B40530
2013-05-28 22:34 ` Scott Wood
2013-05-29 2:11 ` Zhang Ying-B40530
2013-05-29 22:54 ` Scott Wood
2013-05-24 16:07 ` Tom Rini
2013-05-24 16:11 ` Tom Rini [this message]
2013-05-24 19:08 ` Scott Wood
2013-05-24 19:18 ` Tom Rini
2013-05-27 7:43 ` Zhang Ying-B40530
2013-05-20 6:07 ` [U-Boot] [PATCH 6/6] powerpc/p1022ds: boot from SD Card with SPL ying.zhang at freescale.com
2013-05-23 2:29 ` Zhang Ying-B40530
2013-06-21 20:46 ` [U-Boot] [U-Boot, 1/6] powerpc/mpc85xx: support application without resetvec segment in the linker script Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524161101.GS17119@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox