From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] net, cpsw: disable gigabit support through plattform data
Date: Tue, 04 Jun 2013 17:00:45 +0200 [thread overview]
Message-ID: <20130604150045.3454038306D@gemini.denx.de> (raw)
In-Reply-To: <1370335914-14027-1-git-send-email-hs@denx.de>
Dear Heiko,
In message <1370335914-14027-1-git-send-email-hs@denx.de> you wrote:
> add possibility to disable gigabit support through
> plattform data. Current boards should not be affected
> through this patch.
...
> + if (phy->speed == 1000) {
> + if (priv->data.gigabit_en) {
> + mac_control |= GIGABITEN;
> + } else {
> + /* Disable gigabit as it's non-functional */
> + mac_control &= ~GIGABITEN;
> + phy->speed = 100;
Is this reliable? I mean, how do we know it's a 100 Mbps connection
(and not for example a 10 Mbs one) ?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Systems programmers are the high priests of a low cult.
-- R.S. Barton
next prev parent reply other threads:[~2013-06-04 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 8:51 [U-Boot] net, cpsw: disable gigabit support through plattform data Heiko Schocher
2013-06-04 13:58 ` Tom Rini
2013-06-04 15:00 ` Wolfgang Denk [this message]
2013-06-04 15:15 ` Heiko Schocher
2013-06-04 15:29 ` Mugunthan V N
2013-06-05 10:44 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604150045.3454038306D@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox