public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cfi_flash: Add prototypes of overridable functions
Date: Thu, 06 Jun 2013 12:02:56 +0200	[thread overview]
Message-ID: <20130606100256.2A7AC38306D@gemini.denx.de> (raw)
In-Reply-To: <1370505244-5015-1-git-send-email-yamada.m@jp.panasonic.com>

Dear Masahiro Yamada,

In message <1370505244-5015-1-git-send-email-yamada.m@jp.panasonic.com> you wrote:
> This commit adds some prototypes into include/mtd/cfi_flash.h.
> These functions are defined with a weak attribute in
> drivers/mtd/cfi_flash.c.
> This means they can be overrided by board-specific ones
> if necessary.
> 
> When defining such functions under board/ directory or
> somewhere, cfi_flash.h should be included.
> This makes sure that board-specfic cfi functions
> are defined in a correct prototype.

As is, this would just add dead code.  Please resubmit this with any
patch that would actually make use of this feature.  this would also
allow us to understand why this approch is needed at all.

> +#ifdef CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS

When resubmitting, please keep in mind that new CONFIG_* options like
this must be documented in the README.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Here is an Appalachian version of management's answer  to  those  who
are  concerned  with  the fate of the project: "Don't worry about the
mule. Just load the wagon."         - Mike Dennison's hillbilly uncle

  reply	other threads:[~2013-06-06 10:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06  7:54 [U-Boot] [PATCH] cfi_flash: Add prototypes of overridable functions Masahiro Yamada
2013-06-06 10:02 ` Wolfgang Denk [this message]
2013-06-06 11:02   ` Masahiro Yamada
2013-07-25 14:50 ` Stefan Roese
2013-07-30  5:36   ` Masahiro Yamada
2013-07-30  8:33     ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130606100256.2A7AC38306D@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox