From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] cosmetic: arm: fix comments in arch/arm/lib/crt0.S
Date: Mon, 10 Jun 2013 21:25:08 +0200 [thread overview]
Message-ID: <20130610212508.5fea4b1a@lilith> (raw)
In-Reply-To: <1368606796-14018-1-git-send-email-yamada.m@jp.panasonic.com>
Hi Masahiro,
On Wed, 15 May 2013 17:33:16 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>
> Changes for v2:
> - Fix one more comment
>
> Changes for v3:
> - Fix the commit log to indicate
> * this patch is entirely cosmetic
> * which part was changed at a glance
>
> arch/arm/lib/crt0.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S
> index a9657d1..a5bffb8 100644
> --- a/arch/arm/lib/crt0.S
> +++ b/arch/arm/lib/crt0.S
> @@ -97,13 +97,13 @@ ENTRY(_main)
> * 'here' but relocated.
> */
>
> - ldr sp, [r8, #GD_START_ADDR_SP] /* r8 = gd->start_addr_sp */
> + ldr sp, [r8, #GD_START_ADDR_SP] /* sp = gd->start_addr_sp */
> bic sp, sp, #7 /* 8-byte alignment for ABI compliance */
> ldr r8, [r8, #GD_BD] /* r8 = gd->bd */
> sub r8, r8, #GD_SIZE /* new GD is below bd */
>
> adr lr, here
> - ldr r0, [r8, #GD_RELOC_OFF] /* lr = gd->start_addr_sp */
> + ldr r0, [r8, #GD_RELOC_OFF] /* r0 = gd->reloc_off */
> add lr, lr, r0
> ldr r0, [r8, #GD_RELOCADDR] /* r0 = gd->relocaddr */
> b relocate_code
Applied to u-boot-arm/master, thanks!
Amicalement,
--
Albert.
next prev parent reply other threads:[~2013-06-10 19:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 7:12 [U-Boot] [PATCH] arm: fix a comment Masahiro Yamada
2013-05-09 13:12 ` Benoît Thébaudeau
2013-05-10 4:31 ` Masahiro Yamada
2013-05-10 4:21 ` [U-Boot] [PATCH v2] " y at epochmail.jp.panasonic.com
2013-05-10 8:23 ` Masahiro Yamada
2013-05-10 4:24 ` Masahiro Yamada
2013-05-14 1:43 ` Masahiro Yamada
2013-05-14 6:20 ` Albert ARIBAUD
2013-05-15 8:33 ` [U-Boot] [PATCH v3] cosmetic: arm: fix comments in arch/arm/lib/crt0.S Masahiro Yamada
2013-06-10 19:25 ` Albert ARIBAUD [this message]
2013-05-15 8:46 ` [U-Boot] [PATCH v2] arm: fix a comment Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130610212508.5fea4b1a@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox