From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 17/21] arm: Implement the 'fake' go command
Date: Tue, 11 Jun 2013 22:21:52 +0200 [thread overview]
Message-ID: <20130611222152.3dc96387@lilith> (raw)
In-Reply-To: <CAPnjgZ2Lx_Vb+rnb-14_U5t8nVgfjgOMBrH+pbKKeSOd+i+wvQ@mail.gmail.com>
Hi Simon,
On Tue, 11 Jun 2013 13:02:56 -0700, Simon Glass <sjg@chromium.org>
wrote:
> Hi Albert,
>
> On Tue, Jun 11, 2013 at 12:59 PM, Albert ARIBAUD
> <albert.u.boot@aribaud.net>wrote:
>
> > Hi Simon,
> >
> > On Tue, 11 Jun 2013 11:14:49 -0700, Simon Glass <sjg@chromium.org>
> > wrote:
> >
> > > Implement this feature on ARM for tracing.
> > >
> > > It would be nice to have generic bootm support so that it is easily
> > > implemented on any arch.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > ---
> > > Changes in v2: None
> > >
> > > arch/arm/lib/bootm.c | 33 +++++++++++++++++++++------------
> > > 1 file changed, 21 insertions(+), 12 deletions(-)
> > >
> > > diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
> > > index 1b6e0ac..28fba19 100644
> > > --- a/arch/arm/lib/bootm.c
> > > +++ b/arch/arm/lib/bootm.c
> >
> > > @@ -225,14 +232,15 @@ static void boot_prep_linux(bootm_headers_t
> > *images)
> > > }
> > >
> > > /* Subcommand: GO */
> > > -static void boot_jump_linux(bootm_headers_t *images)
> > > +static void boot_jump_linux(bootm_headers_t *image, int flag)
> >
> > What's the rationale of the s/images/image/ ?
> >
>
> Just that the function only accesses a single image, so I felt it was a
> misnomer.
I wonder if the naming was not initially chosen to remind readers that
this single image file may actually contain several images
(kernel+initrd, for instance.
> Regards,
> Simon
Amicalement,
--
Albert.
next prev parent reply other threads:[~2013-06-11 20:21 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 18:14 [U-Boot] [PATCH v2 0/21] Add tracing functionality to U-Boot Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 01/21] pci: Convert extern inline functions to static inline Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 02/21] x86: Correct missing local variable in bootm Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 03/21] Fix missing return in do_mem_loop() Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 04/21] Show stdout on error in fit-test Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 05/21] bootstage: Correct printf types Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 06/21] Add function to print a number with grouped digits Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 07/21] Add trace library Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 08/21] Add a trace command Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 09/21] Support tracing in config.mk when enabled Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 10/21] Add trace support to generic board Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 11/21] Add proftool to decode profile data Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 12/21] sandbox: Support trace feature Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 13/21] Add a simple test for sandbox trace Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 14/21] Clarify bootm OS arguments Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication Simon Glass
2013-06-27 13:40 ` Stefan Roese
2013-06-27 14:40 ` Tom Rini
2013-06-27 15:39 ` Simon Glass
2013-06-27 19:51 ` Simon Glass
2013-06-27 20:07 ` Tom Rini
2013-06-28 2:14 ` Simon Glass
2013-06-28 4:12 ` Stefan Roese
2013-06-28 5:44 ` Simon Glass
2013-06-28 6:58 ` Simon Glass
2013-06-28 7:04 ` Stefan Roese
2013-06-28 7:12 ` Simon Glass
2013-06-28 7:57 ` Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 16/21] Add a 'fake' go command to the bootm command Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 17/21] arm: Implement the 'fake' go command Simon Glass
2013-06-11 19:59 ` Albert ARIBAUD
2013-06-11 20:02 ` Simon Glass
2013-06-11 20:21 ` Albert ARIBAUD [this message]
2013-06-11 21:17 ` Simon Glass
2013-06-11 21:36 ` Albert ARIBAUD
2013-06-20 4:16 ` Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 18/21] exynos: Avoid function instrumentation for microsecond timer Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 19/21] exynos: config: Add tracing options Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 20/21] x86: Support tracing function Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 21/21] x86: config: Add tracing options Simon Glass
2013-06-26 20:24 ` [U-Boot] [PATCH v2 0/21] Add tracing functionality to U-Boot Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130611222152.3dc96387@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox