From: Andy Fleming <afleming@right.am.freescale.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,V2] MMC: DWMMC: Fix FIFO_DEPTH calculation
Date: Thu, 13 Jun 2013 17:34:48 -0500 [thread overview]
Message-ID: <20130613223448.GA29946@right.am.freescale.net> (raw)
In-Reply-To: <1369399534-30320-1-git-send-email-rajeshwari.s@samsung.com>
On Fri, May 24, 2013 at 06:15:34PM +0530, Rajeshwari Shinde wrote:
> Current DWMMC driver used to give FIFO underrun/overrun error every 3rd time
> for mmc rescan command.
> In current code FIFO_DEPTH is getting calculated after reading the default FIFOTH
> register and extracting the RX_WMARK bits from it i.e (RX_WMARK = FIFO_DEPTH/2 -1).
> Instead of storing the correct value, we were recalculating the FIFO_DEPT each
> time which is not correct.
>
> Based on "[PATCH V9 3/9] DWMMC: Initialise dwmci and resolve EMMC read write issues"
> http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/160247
>
> Signed-off-by: Hatim Ali <hatim.rv@samsung.com>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> Tested-by: Simon Glass <sjg@chromium.org>
> Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Acked-by: Andy Fleming <afleming@freescale.com>
Looks like the patch this is based on is already accepted, but not yet
upstream, so I'm going to delegate the patch to Minkyu Kang
next prev parent reply other threads:[~2013-06-13 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 12:45 [U-Boot] [PATCH V2] MMC: DWMMC: Fix FIFO_DEPTH calculation Rajeshwari Shinde
2013-05-26 20:32 ` Simon Glass
2013-05-27 3:43 ` Jaehoon Chung
2013-06-13 22:34 ` Andy Fleming [this message]
2013-06-17 2:07 ` [U-Boot] [U-Boot,V2] " Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613223448.GA29946@right.am.freescale.net \
--to=afleming@right.am.freescale.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox