From: Thierry Reding <thierry.reding@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/3] ARM: Tegra: USB: EHCI: Add support for Tegra30/Tegra114
Date: Mon, 17 Jun 2013 12:43:11 +0200 [thread overview]
Message-ID: <20130617104254.GA30265@manwe> (raw)
In-Reply-To: <1371460197-17912-2-git-send-email-jilin@nvidia.com>
On Mon, Jun 17, 2013 at 05:09:56PM +0800, Jim Lin wrote:
[...]
> diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c
> index 8d7a227..f0f81c9 100644
> --- a/board/nvidia/common/board.c
> +++ b/board/nvidia/common/board.c
> @@ -46,7 +46,7 @@
> #include <asm/arch/emc.h>
> #endif
> #ifdef CONFIG_USB_EHCI_TEGRA
> -#include <asm/arch-tegra/usb.h>
> +#include <asm/arch/usb.h>
> #endif
> #ifdef CONFIG_TEGRA_MMC
> #include <asm/arch-tegra/tegra_mmc.h>
With this hunk applied I get the following new build warning:
../../nvidia/common/board.c: In function 'board_init':
../../nvidia/common/board.c:171:2: warning: implicit declaration of function 'board_usb_init' [-Wimplicit-function-declaration]
board_usb_init(gd->fdt_blob);
^
Reverting that one hunk makes the warning go away again and everything
still builds fine, so I think it can just be removed from the patch.
Besides the one issue I'm still seeing with the very old flash drive,
which might turn out not to be specific to Tegra, this series:
Tested-by: Thierry Reding <thierry.reding@gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130617/83ed2a1d/attachment.pgp>
next prev parent reply other threads:[~2013-06-17 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 9:09 [U-Boot] [PATCH v3 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114 Jim Lin
2013-06-17 9:09 ` [U-Boot] [PATCH v3 2/3] ARM: Tegra: USB: EHCI: Add support for Tegra30/Tegra114 Jim Lin
2013-06-17 10:43 ` Thierry Reding [this message]
2013-06-17 16:44 ` Stephen Warren
2013-06-17 9:09 ` [U-Boot] [PATCH v3 3/3] Tegra: Config: Enable Tegra30/Tegra114 USB function Jim Lin
2013-06-17 16:48 ` Stephen Warren
2013-06-17 20:41 ` Marek Vasut
2013-06-17 16:29 ` [U-Boot] [PATCH v3 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114 Stephen Warren
2013-06-17 20:42 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617104254.GA30265@manwe \
--to=thierry.reding@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox