public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: mxs: Make the console buffer smaller
Date: Mon, 17 Jun 2013 14:51:39 +0200	[thread overview]
Message-ID: <201306171451.39362.marex@denx.de> (raw)
In-Reply-To: <51BEE9CD.8090002@denx.de>

Hello Stefano,

I'm CCing Wolfgang,

> Hi Marek,
> 
> On 15/06/2013 23:41, Marek Vasut wrote:
> > Using 1024 bytes for console buffer is unnecessarily too much,
> > lower the amount for all MXS boards to 256.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Lauri Hintsala <lauri.hintsala@bluegiga.com>
> > Cc: Otavio Salvador <otavio@ossystems.com.br>
> > Cc: Stefano Babic <sbabic@denx.de>
> > ---
> > 
> >  include/configs/mxs.h |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Note: This depends on http://patchwork.ozlabs.org/patch/251631/
> > 
> > diff --git a/include/configs/mxs.h b/include/configs/mxs.h
> > index a684166..161d89d 100644
> > --- a/include/configs/mxs.h
> > +++ b/include/configs/mxs.h
> > @@ -92,7 +92,7 @@
> > 
> >  #ifndef CONFIG_SYS_PROMPT
> >  #define CONFIG_SYS_PROMPT	"=> "
> >  #endif
> > 
> > -#define CONFIG_SYS_CBSIZE	1024		/* Console I/O buffer size */
> > +#define CONFIG_SYS_CBSIZE	256		/* Console I/O buffer size */
> > 
> >  #define CONFIG_SYS_PBSIZE	\
> >  
> >  	(CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
> >  	
> >  						/* Print buffer size */
> 
> I am missing something: which is the real advantage to reduce the
> console buffer ? I do not think that the saved memory is worth, and on
> the other side more elaborated scripts (usings nested if-then-else) are
> quite long nowadays.

True, but so far they didn't overflow this limit I believe. Some of them are 
hanging on the verge of blowing it though, good point.

Best regards,
Marek Vasut

  reply	other threads:[~2013-06-17 12:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-15 21:41 [U-Boot] [PATCH] ARM: mxs: Make the console buffer smaller Marek Vasut
2013-06-17 10:49 ` Stefano Babic
2013-06-17 12:51   ` Marek Vasut [this message]
2013-06-17 13:07     ` Stefano Babic
2013-06-17 13:13       ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201306171451.39362.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox