public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix block device accesses beyond 2TiB
Date: Mon, 17 Jun 2013 22:26:00 +0200	[thread overview]
Message-ID: <201306172226.01044.marex@denx.de> (raw)
In-Reply-To: <1371208045-4428-1-git-send-email-t-uboot@infra-silbe.de>

Hello Sascha,

> With CONFIG_SYS_64BIT_LBA, lbaint_t gets defined as a 64-bit type,
> which is required to represent block numbers for storage devices that
> exceed 2TiB (the block size usually is 512B), e.g. recent hard drives.
> 
> For some obscure reason, the current U-Boot code uses lbaint_t for the
> number of blocks to read (a rather optimistic estimation of how RAM
> sizes will evolve), but not for the starting address. Trying to access
> blocks beyond the 2TiB boundary will simply wrap around and read a
> block within the 0..2TiB range.
> 
> We now use lbaint_t for block start addresses, too. This required
> changes to all block drivers as the signature of block_read(),
> block_write() and block_erase() in block_dev_desc_t changed.
> 
> Signed-off-by: Sascha Silbe <t-uboot@infra-silbe.de>
> ---
> Functionality tested on CuBox Pro with a Western Digital WD30EFRX hard
> disk (3TB). Build tested for all arm boards and sandbox.
> 
> Testing on other boards and architectures would be appreciated.
> 
> Fixes for typos, style errors etc. are explicitly out of scope for
> this patch, even those checkpatch complains about because they appear
> on or near lines touched by the patch. They are unrelated to the issue
> at hand and can be fixed up later. Mixing in unrelated changes would
> just make harder to revert any problematic change.

Quick review looks OK.

Best regards,
Marek Vasut

  reply	other threads:[~2013-06-17 20:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10 13:30 [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB Frederic Leroy
2013-06-10 13:44 ` Simon Guinot
2013-06-10 14:20   ` Frédéric Leroy
2013-06-10 14:29     ` Simon Guinot
2013-06-10 14:48       ` Albert ARIBAUD
2013-06-13 11:33 ` Albert ARIBAUD
2013-06-13 13:03   ` Frédéric Leroy
2013-06-13 13:21     ` Albert ARIBAUD
2013-06-13 13:36       ` Frédéric Leroy
2013-06-13 20:32     ` Sascha Silbe
2013-06-14 11:07       ` [U-Boot] [PATCH] Fix block device accesses beyond 2TiB Sascha Silbe
2013-06-17 20:26         ` Marek Vasut [this message]
2013-06-22 10:07           ` Albert ARIBAUD
     [not found]             ` <51C598A6.8040406@starox.org>
2013-06-22 15:31               ` Albert ARIBAUD
2013-06-24  9:46                 ` Frédéric Leroy
2013-06-24 21:13                   ` Sascha Silbe
2013-06-24 21:26                     ` [U-Boot] [PATCH] Fix ext2/ext4 filesystem " Frederic Leroy
2013-06-24 22:26                       ` Sascha Silbe
2013-06-25  6:10                         ` Frederic Leroy
2013-06-25 20:42                           ` Sascha Silbe
2013-06-26 16:11                             ` [U-Boot] [PATCH v2] " Frédéric Leroy
2013-07-11 10:41                               ` Albert ARIBAUD
2013-07-16 14:37                               ` [U-Boot] [U-Boot, " Tom Rini
2013-06-26 20:25         ` [U-Boot] Fix block device " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201306172226.01044.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox