From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 20 Jun 2013 22:19:20 +0200 Subject: [U-Boot] [PATCH] arm: fix memory coherency problem after relocation In-Reply-To: <51C33600.2070103@newsguy.com> References: <1371492435-14330-1-git-send-email-mikedunn@newsguy.com> <201306201556.27564.marex@denx.de> <51C33600.2070103@newsguy.com> Message-ID: <201306202219.20646.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Dunn, > On 06/20/2013 06:56 AM, Marek Vasut wrote: > > Dear Mike Dunn, > > > >> On the xscale, the icache must be invalidated and the write buffers > >> drained after writing code over the data bus, even if the caches are > >> disabled. After rebasing with the main git repository, u-boot began > >> crashing in odd places on my pxa270 board (palmtreo680) after the code > >> relocation routine ran. This patch fixes it. Cache coherency problems > >> are often > >> hit-and-miss (ha ha), and this latent problem didn't rear its ugly head > >> until now. Tested on the pxa270. > >> > >> Signed-off-by: Mike Dunn > >> --- > >> > >> I realize that __ARM_ARCH_5TE__ does not necessarily mean xscale. > > > > We should introduce some CONFIG_PXA I guess. > > I think CONFIG_XSCALE is more correct, because if I'm not mistaken more > recent Marvell processors continue to use the 'pxa' nomenclature in their > name but do not contain xscale cores. I suspect we might end up checking all the datasheets (PXA2xx, PXA3xx and PXA9xx) to see which CPUs still need this fixup. Best regards, Marek Vasut