From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] pxa: fix memory coherency problem after relocation
Date: Sat, 22 Jun 2013 04:29:56 +0200 [thread overview]
Message-ID: <201306220429.56662.marex@denx.de> (raw)
In-Reply-To: <1371831148-22380-3-git-send-email-mikedunn@newsguy.com>
Dear Mike Dunn,
> On the xscale, the icache must be invalidated and the write buffers drained
> after writing code over the data bus, even if the caches are disabled.
> Tested on the pxa270.
>
> Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
> ---
> arch/arm/lib/relocate.S | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/lib/relocate.S b/arch/arm/lib/relocate.S
> index 4446da9..eedf314 100644
> --- a/arch/arm/lib/relocate.S
> +++ b/arch/arm/lib/relocate.S
> @@ -92,6 +92,15 @@ fixnext:
>
> relocate_done:
>
> +#ifdef __XSCALE__
> + /*
> + * On xscale, icache must be invalidated and write buffers drained,
> + * even with cache disabled - 4.2.7 of xscale core developer's manual
> + */
> + mcr p15, 0, r0, c7, c7, 0 /* invalidate icache */
> + mcr p15, 0, r0, c7, c10, 4 /* drain write buffer */
> +#endif
> +
> /* ARMv4- don't know bx lr but the assembler fails to see that */
>
> #ifdef __ARM_ARCH_4__
Acked-by: Marek Vasut <marex@denx.de>
Albert, do you want me to pick these or will you?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-06-22 2:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 16:12 [U-Boot] [PATCH 0/2] pxa: fix memory coherency problem after relocation Mike Dunn
2013-06-21 16:12 ` [U-Boot] [PATCH 1/2] pxa: use -mcpu=xscale compiler option Mike Dunn
2013-06-22 2:29 ` Marek Vasut
2013-06-21 16:12 ` [U-Boot] [PATCH 2/2] pxa: fix memory coherency problem after relocation Mike Dunn
2013-06-22 2:29 ` Marek Vasut [this message]
2013-06-22 5:23 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306220429.56662.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox