public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay
Date: Mon, 24 Jun 2013 19:11:44 +0200	[thread overview]
Message-ID: <20130624191144.43de6085@lilith> (raw)
In-Reply-To: <716F60BA84FACB40B8512358C4532C1DC48846@039-SN1MPN1-002.039d.mgd.msft.net>

Hi Rai,

On Mon, 24 Jun 2013 09:28:26 +0000, Rai Harninder-B01044
<B01044@freescale.com> wrote:

> Hello Albert,
> 
> 
> Plase fix commit message: you're not simply adding a boot delay flag, you're in fact disabling autoboot, which is quite different.
> [Rai Harninder-B01044] "Disable autoboot through bootdelay config flag". Is this ok?

(weird way of quoting messages; makes it really hard to see who said
what. Can't your mail client use the standard ">" line prefix?)

As for the commit summary, it is fine by me.

> Also, when touching on a board's code, you should Cc: the board's maintainer(s). Please do so for V2 of your patch -- and if you get a non-delivery status (e.g. a maintainer's mail address does not exist any more), please follow up on your patch submission to let us know.
> [Rai Harninder-B01044] The board's maintainer is Andy Fleming who is already included in cc

Are you not mixing up BSC9131RDB and BSC9132QDS maintainership with
MPC85xx tree custodianship?

Andy is the MPC85xx custodian, but has no entry in the MAINTAINERS
file, which OTOH lists Poonam Aggrwal <poonam.aggrwal@freescale.com> as
the BSC9131RDB maintainer, and Naveen Burmi <NaveenBurmi@freescale.com>
as the BSC9132QDS one.

> Harry++

Amicalement,
-- 
Albert.

  reply	other threads:[~2013-06-24 17:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 11:48 [U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay Harninder Rai
2013-06-23  7:07 ` Albert ARIBAUD
2013-06-24  9:28   ` Rai Harninder-B01044
2013-06-24 17:11     ` Albert ARIBAUD [this message]
2013-06-25 12:38       ` Rai Harninder-B01044
2013-06-25 17:45         ` Scott Wood
2013-06-25  0:01     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130624191144.43de6085@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox