From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm: add support for LaCie CloudBox
Date: Tue, 25 Jun 2013 20:24:03 +0200 [thread overview]
Message-ID: <20130625182403.F02BA380468@gemini.denx.de> (raw)
In-Reply-To: <1372178945-11528-2-git-send-email-fredo@starox.org>
Dear Frederic Leroy,
In message <1372178945-11528-2-git-send-email-fredo@starox.org> you wrote:
> From: Fr?d?ric Leroy <fredo@starox.org>
>
> The LaCie CloudBox device is a Kirkwood based nas :
>
> - SoC: Marvell 88F6700 1000Mhz
> - SDRAM memory: 256MB DDR2 400Mhz
> - Gigabit ethernet: PHY Marvell 88E1318
> - Flash memory: SPI NOR 512KB (Macronix MX25L4005A)
> - 1 push button
> - 1 reset switch
> - 1 SATA port
> - 1 LED (bi-color, blue and red)
>
> Signed-off-by: Fr?d?ric Leroy <fredo@starox.org>
> ---
> board/LaCie/cloudbox/Makefile | 46 +++++++++++
> board/LaCie/cloudbox/cloudbox.c | 104 ++++++++++++++++++++++++
> board/LaCie/cloudbox/cloudbox.h | 36 ++++++++
> board/LaCie/cloudbox/kwbimage.cfg | 167 ++++++++++++++++++++++++++++++++++++++
> boards.cfg | 1 +
> include/configs/lacie_kw.h | 8 +-
> 6 files changed, 361 insertions(+), 1 deletion(-)
> create mode 100644 board/LaCie/cloudbox/Makefile
> create mode 100644 board/LaCie/cloudbox/cloudbox.c
> create mode 100644 board/LaCie/cloudbox/cloudbox.h
> create mode 100644 board/LaCie/cloudbox/kwbimage.cfg
The (mandatory) entry to MAINTAINERS is missing.
Checkpatch says:
WARNING: please, no spaces at the start of a line
#253: FILE: board/LaCie/cloudbox/cloudbox.c:82:
+ return 0;$
WARNING: line over 80 characters
#525: FILE: include/configs/lacie_kw.h:79:
+#if !defined(CONFIG_NETSPACE_MINI_V2) && !defined(CONFIG_CLOUDBOX) /* No USB ports on these devices */
Please clean these up.
> index e2b3b21..dc101d6 100644
> --- a/include/configs/lacie_kw.h
> +++ b/include/configs/lacie_kw.h
> @@ -44,6 +44,8 @@
> #elif defined(CONFIG_NET2BIG_V2)
> #define CONFIG_MACH_TYPE MACH_TYPE_NET2BIG_V2
> #define CONFIG_IDENT_STRING " 2Big v2"
> +#elif defined(CONFIG_CLOUDBOX)
> +#define CONFIG_IDENT_STRING " CloudBox"
Please keep such lists alphabetically sorted.
> @@ -115,6 +119,8 @@
> #define CONFIG_SYS_PROMPT "d2v2> "
> #elif defined(CONFIG_NET2BIG_V2)
> #define CONFIG_SYS_PROMPT "2big2> "
> +#elif defined(CONFIG_CLOUDBOX)
> +#define CONFIG_SYS_PROMPT "cb> "
Same here again.
On the other hand, this is actually crap. We should use a common
prompt for all these boards, eventually the standard "=> ".
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There is nothing so deadly as not to hold up to people the
opportunity to do great and wonderful things, if we wish to stimulate
them in an active way."
- Dr. Harold Urey, Nobel Laureate in chemistry
next prev parent reply other threads:[~2013-06-25 18:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 16:49 [U-Boot] [PATCH 0/2] add support for LaCie CloudBox Frederic Leroy
2013-06-25 16:49 ` [U-Boot] [PATCH 1/2] arm: " Frederic Leroy
2013-06-25 18:24 ` Wolfgang Denk [this message]
2013-06-30 10:12 ` [U-Boot] [PATCH v2 0/4] " Frédéric Leroy
2013-06-30 10:12 ` [U-Boot] [PATCH v2 1/4] lacie_kw: sort #ifdef lists by CONFIG_ identifiers Frédéric Leroy
2013-06-30 22:15 ` Simon Guinot
2013-06-30 10:12 ` [U-Boot] [PATCH v2 2/4] arm: add support for LaCie CloudBox Frédéric Leroy
2013-06-30 10:12 ` [U-Boot] [PATCH v2 3/4] LaCie/common: Fix cloudbox ethernet leds Frédéric Leroy
2013-06-30 23:01 ` Simon Guinot
2013-07-01 9:51 ` [U-Boot] compiled failed when turned off gcc optimazition TigerLiu at viatech.com.cn
2013-07-01 10:03 ` Wolfgang Denk
2013-07-01 10:08 ` TigerLiu at viatech.com.cn
2013-07-01 11:37 ` Wolfgang Denk
2013-07-01 18:03 ` Mike Dunn
2013-07-01 19:51 ` Wolfgang Denk
2013-07-02 19:40 ` Mike Dunn
2013-07-02 22:38 ` Graeme Russ
2013-07-05 10:31 ` TigerLiu at viatech.com.cn
2013-07-05 14:00 ` [U-Boot] compiled failed when turned off gcc optimazitionAT Albert ARIBAUD
2013-06-30 10:12 ` [U-Boot] [PATCH v2 4/4] arm: add machine ID for CloudBox Frédéric Leroy
2013-06-30 22:53 ` Simon Guinot
2013-07-01 9:30 ` Frédéric Leroy
2013-07-01 10:01 ` Simon Guinot
2013-06-25 20:50 ` [U-Boot] [PATCH 1/2] arm: add support for LaCie CloudBox Simon Guinot
2013-06-25 21:09 ` Simon Guinot
2013-06-25 16:49 ` [U-Boot] [PATCH 2/2] LaCie/common: Fix cloudbox ethernet leds Frederic Leroy
2013-06-25 18:27 ` Wolfgang Denk
2013-06-25 21:08 ` Simon Guinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625182403.F02BA380468@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox