public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Simon Guinot <simon.guinot@sequanux.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] LaCie/common: Fix cloudbox ethernet leds
Date: Tue, 25 Jun 2013 23:08:05 +0200	[thread overview]
Message-ID: <20130625210805.GF7626@kw.sim.vm.gnt> (raw)
In-Reply-To: <1372178945-11528-3-git-send-email-fredo@starox.org>

On Tue, Jun 25, 2013 at 06:49:05PM +0200, Frederic Leroy wrote:
> From: Fr?d?ric Leroy <fredo@starox.org>
> 
> The cloudbox device have a different ethernet phy setup than other ns2
> devices. We get initialization value from the GPL LaCie source
> 
> Signed-off-by: Fr?d?ric Leroy <fredo@starox.org>
> ---
>  board/LaCie/common/common.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/board/LaCie/common/common.c b/board/LaCie/common/common.c
> index a62bf9f..d828685 100644
> --- a/board/LaCie/common/common.c
> +++ b/board/LaCie/common/common.c
> @@ -52,10 +52,18 @@ void mv_phy_88e1318_init(const char *name, u16 phyaddr)
>  	/*
>  	 * Set control mode 4 for LED[0].
>  	 */
> +	#ifndef CONFIG_CLOUDBOX
>  	miiphy_write(name, phyaddr, MII_MARVELL_PHY_PAGE, 3);
>  	miiphy_read(name, phyaddr, 16, &reg);
>  	reg |= 0xf;
>  	miiphy_write(name, phyaddr, 16, reg);
> +	#else
> +	miiphy_write(name, phyaddr, MII_MARVELL_PHY_PAGE, 3);
> +	miiphy_read(name, phyaddr, 17, &reg);
> +	reg &= ~0x3f;
> +	reg |= 0x15;
> +	miiphy_write(name, phyaddr, 17, reg);
> +	#endif

This doesn't look very common but I can't figure out a more elegant way.

Acked-by: Simon Guinot <simon.guinot@sequanux.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130625/f97b0809/attachment.pgp>

      parent reply	other threads:[~2013-06-25 21:08 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25 16:49 [U-Boot] [PATCH 0/2] add support for LaCie CloudBox Frederic Leroy
2013-06-25 16:49 ` [U-Boot] [PATCH 1/2] arm: " Frederic Leroy
2013-06-25 18:24   ` Wolfgang Denk
2013-06-30 10:12     ` [U-Boot] [PATCH v2 0/4] " Frédéric Leroy
2013-06-30 10:12       ` [U-Boot] [PATCH v2 1/4] lacie_kw: sort #ifdef lists by CONFIG_ identifiers Frédéric Leroy
2013-06-30 22:15         ` Simon Guinot
2013-06-30 10:12       ` [U-Boot] [PATCH v2 2/4] arm: add support for LaCie CloudBox Frédéric Leroy
2013-06-30 10:12       ` [U-Boot] [PATCH v2 3/4] LaCie/common: Fix cloudbox ethernet leds Frédéric Leroy
2013-06-30 23:01         ` Simon Guinot
2013-07-01  9:51           ` [U-Boot] compiled failed when turned off gcc optimazition TigerLiu at viatech.com.cn
2013-07-01 10:03             ` Wolfgang Denk
2013-07-01 10:08               ` TigerLiu at viatech.com.cn
2013-07-01 11:37                 ` Wolfgang Denk
2013-07-01 18:03                   ` Mike Dunn
2013-07-01 19:51                     ` Wolfgang Denk
2013-07-02 19:40                       ` Mike Dunn
2013-07-02 22:38                         ` Graeme Russ
2013-07-05 10:31                           ` TigerLiu at viatech.com.cn
2013-07-05 14:00                             ` [U-Boot] compiled failed when turned off gcc optimazitionAT Albert ARIBAUD
2013-06-30 10:12       ` [U-Boot] [PATCH v2 4/4] arm: add machine ID for CloudBox Frédéric Leroy
2013-06-30 22:53         ` Simon Guinot
2013-07-01  9:30           ` Frédéric Leroy
2013-07-01 10:01             ` Simon Guinot
2013-06-25 20:50   ` [U-Boot] [PATCH 1/2] arm: add support for LaCie CloudBox Simon Guinot
2013-06-25 21:09     ` Simon Guinot
2013-06-25 16:49 ` [U-Boot] [PATCH 2/2] LaCie/common: Fix cloudbox ethernet leds Frederic Leroy
2013-06-25 18:27   ` Wolfgang Denk
2013-06-25 21:08   ` Simon Guinot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130625210805.GF7626@kw.sim.vm.gnt \
    --to=simon.guinot@sequanux.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox