From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 26 Jun 2013 21:56:43 +0200 Subject: [U-Boot] [PATCH V2] ARM: mxs: Consolidate configuration options In-Reply-To: <51CAFD67.7050409@denx.de> References: <1371316336-31711-1-git-send-email-marex@denx.de> <1371389942-23081-1-git-send-email-marex@denx.de> <51CAFD67.7050409@denx.de> Message-ID: <201306262156.43650.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, > Hi Marek, > > On 16/06/2013 15:39, Marek Vasut wrote: > > Pull all the duplicate configuration options into configs/mxs.h > > from the board configuration files. This reduces the files greatly > > and makes them somewhat more readable. Besides, we do no longer > > have such a horrible duplication of code. > > > > Note that the mx23evk grew in size slightly. This is due to the > > CONFIG_SYS_CBSIZE now being set to 1024 as it is on the rest of > > MXS systems. > > > > This patch also fixes the OCRAM size for i.MX23. The i.MX23 has > > only 32kB of OCRAM, while i.MX28 has 128kB of OCRAM. > > > > I verified the configuration didn't change for each of the boards, > > but I didn't boot-test it on the boards I do not have. I configured > > U-Boot for each board using the "make ... _config" command > > and then ran "cpp -I include -dM include/config.h" , which dumped > > all the configuration options. I did this both before and after this > > patch and finally compared the results for each MXS board. Actually, > > the results do differ slightly, since the configs/mxs.h file now > > properly includes the correct iomux-mx23.h or iomux-mx28.h , so > > while comparing, I had to ignore these new defines. These have no > > impact on U-Boot configuration though. > > > > Signed-off-by: Marek Vasut > > Cc: Fabio Estevam > > Cc: Lauri Hintsala > > Cc: Otavio Salvador > > Cc: Stefano Babic > > --- > > This is a nice cleanup, but as we probably cannot test all boards before > release, I apply it to u-boot-imx, next branch. Come on guys, test this! I know you want to have it in current release ;-) Best regards, Marek Vasut