public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] PPC MPC83xx: Fix MPC8323ERDB build warning
Date: Thu, 27 Jun 2013 08:22:34 +0200	[thread overview]
Message-ID: <20130627062234.7FDA6380468@gemini.denx.de> (raw)
In-Reply-To: <1371198068-3581-1-git-send-email-wd@denx.de>

Dear Kim,

ping!!

In message <1371198068-3581-1-git-send-email-wd@denx.de> I wrote:
> Fix:
> 
> mpc8323erdb.c: In function 'mac_read_from_eeprom':
> mpc8323erdb.c:198:3: warning: dereferencing type-punned pointer will
> break strict-aliasing rules [-Wstrict-aliasing]
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> cc: Michael Barkowski <michael.barkowski@freescale.com>
> cc: Kim Phillips <kim.phillips@freescale.com>
> ---
>  board/freescale/mpc8323erdb/mpc8323erdb.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mpc8323erdb/mpc8323erdb.c b/board/freescale/mpc8323erdb/mpc8323erdb.c
> index f29b2f4..533cb08 100644
> --- a/board/freescale/mpc8323erdb/mpc8323erdb.c
> +++ b/board/freescale/mpc8323erdb/mpc8323erdb.c
> @@ -195,7 +195,11 @@ int mac_read_from_eeprom(void)
>  		printf("\nEEPROM @ 0x%02x read FAILED!!!\n",
>  		       CONFIG_SYS_I2C_EEPROM_ADDR);
>  	} else {
> -		if (crc32(crc, buf, 24) == *(unsigned int *)&buf[24]) {
> +		unsigned int crc_buf;
> +
> +		memcpy(&crc_buf, &buf[24], sizeof(unsigned int));
> +
> +		if (crc32(crc, buf, 24) == crc_buf) {
>  			printf("Reading MAC from EEPROM\n");
>  			for (i = 0; i < 4; i++) {
>  				if (memcmp(&buf[i * 6], "\0\0\0\0\0\0", 6)) {
> -- 
> 1.7.11.7
> 

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Einstein argued that there must be simplified explanations of nature,
because God is not capricious or arbitrary. No  such  faith  comforts
the software engineer.                             - Fred Brooks, Jr.

  parent reply	other threads:[~2013-06-27  6:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  8:21 [U-Boot] [PATCH 2/2] PPC MPC83xx: Fix MPC8323ERDB build warning Wolfgang Denk
2013-06-14  9:14 ` Wolfgang Denk
2013-06-28 21:47   ` Andy Fleming
2013-06-29  4:11     ` Timur Tabi
2013-06-29  6:04       ` Sinan Akman
2013-07-04  6:15       ` Wolfgang Denk
2013-06-27  6:22 ` Wolfgang Denk [this message]
2013-07-04 12:57 ` Timur Tabi
2013-07-08 18:19   ` [U-Boot] [PATCH 2/2 V2] " Wolfgang Denk
2013-07-08 22:04     ` Timur Tabi
2013-07-14 17:44       ` Wolfgang Denk
2013-07-08 18:23   ` Wolfgang Denk
2013-07-14 17:42   ` [U-Boot] [PATCH 2/2 V3] " Wolfgang Denk
2013-07-14 22:24     ` Timur Tabi
2013-07-16 14:36     ` [U-Boot] [U-Boot, 2/2, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130627062234.7FDA6380468@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox