public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fs/ext4: caculate log2blksz from blksz, other its value = 0
Date: Thu, 27 Jun 2013 12:17:25 +0200	[thread overview]
Message-ID: <20130627121725.7541eb25@lilith> (raw)
In-Reply-To: <1372326151-22868-1-git-send-email-dennis.yxun@gmail.com>

Hi Lan,

On Thu, 27 Jun 2013 17:42:31 +0800, "Lan Yixun (dlan)"
<dennis.yxun@gmail.com> wrote:

> From: "Lan Yixun (dlan)" <dennis.yxun@gmail.com>
> 
> err:
> lt703a # ext4ls nand 3:0
> Failed to mount ext2 filesystem...
> ** Unrecognized filesystem type **
> 
> bug may introduced by commit:
> 
> commit 50ce4c07df1c98aabf4630b35152ed95a87242f7
> Author: Egbert Eich <eich@suse.com>
> Date:   Wed May 1 01:13:19 2013 +0000
> 
>     fs/ext4: Support device block sizes != 512 bytes

Please make the commit summary a description of what is wrong and how
it is fixed, and move the context (how the bug was found, console
output, etc) after the commit message separator '---' below.

Also, fix probably typo in the commit summary (first commit message
line) ("other" for "otherwise").

> Signed-off-by: Lan Yixun (dlan) <dennis.yxun@gmail.com>
> ---
>  disk/part.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/disk/part.c b/disk/part.c
> index fc8404d..dbc94c4 100644
> --- a/disk/part.c
> +++ b/disk/part.c
> @@ -551,6 +551,8 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str,
>  			goto cleanup;
>  		}
>  
> +		(*dev_desc)->log2blksz = LOG2((*dev_desc)->blksz);
> +
>  		info->start = 0;
>  		info->size = (*dev_desc)->lba;
>  		info->blksz = (*dev_desc)->blksz;
> @@ -634,6 +636,8 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str,
>  		goto cleanup;
>  	}
>  
> +	(*dev_desc)->log2blksz = LOG2((*dev_desc)->blksz);
> +
>  	ret = part;
>  	goto cleanup;
>  


Amicalement,
-- 
Albert.

  reply	other threads:[~2013-06-27 10:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27  9:42 [U-Boot] [PATCH] fs/ext4: caculate log2blksz from blksz, other its value = 0 Lan Yixun
2013-06-27 10:17 ` Albert ARIBAUD [this message]
2013-06-28  1:47   ` Dennis Lan
2013-07-19 12:36     ` Dennis Lan
2013-07-19 13:58       ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130627121725.7541eb25@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox