From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 27 Jun 2013 18:52:32 +0200 Subject: [U-Boot] [PATCH] usb: fix unaligned access in device_qual() In-Reply-To: <201306271523.33879.marex@denx.de> References: <1372320297-16275-1-git-send-email-hs@denx.de> <201306271326.39806.marex@denx.de> <20130627140633.6e118472@lilith> <201306271523.33879.marex@denx.de> Message-ID: <20130627185232.38359742@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, On Thu, 27 Jun 2013 15:23:33 +0200, Marek Vasut wrote: > Hello Albert, > > > Hi Marek, > > > > On Thu, 27 Jun 2013 13:26:39 +0200, Marek Vasut wrote: > > > Dear Heiko Schocher, > > > > > > > while playing with dfu, I tapped in an unaligned access > > > > when doing on the host side a "lsusb -d [vendornr]: -v" > > > > > > > I get on the board: > > > Applied, thanks > > > > Now we have console log output in commit messages. :( > > Don't be sad, I will buy you a tartelette ;) Actually the sad part is that the patch in itself is bad: the actual alignment boundary should have been 16 bit, not one cacheline. Also, the issue could / should have been solved by reordering the fields rather than using an attribute. And I'm not going to eat a tartelette when I'm about 30 minutes from going to a restaurant (admittedly small, but undoubtedly near). > Best regards, > Marek Vasut Amicalement, -- Albert.