From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix bootm to work on powerpc again (compressed uImage)
Date: Fri, 28 Jun 2013 09:03:22 -0400 [thread overview]
Message-ID: <20130628130322.GH28078@bill-the-cat> (raw)
In-Reply-To: <1372406523-5726-1-git-send-email-sr@denx.de>
On Fri, Jun 28, 2013 at 10:02:03AM +0200, Stefan Roese wrote:
> Patch 35fc84fa1 [Refactor the bootm command to reduce code duplication]
> breaks booting Linux (compressed uImage with fdt) on powerpc.
>
> boot_jump_linux() mustn't be called before boot_prep_linux() and
> boot_body_linux() have been called. So remove the superfluous call
> to boot_jump_linux() in arch/powerpc/lib/bootm.c as its called later on
> in this function.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@ti.com>
> ---
> Simon, I'm not 100% sure why this is triggered by your patch.
>
> As you see, my patch only fixes powerpc. ARM might have the same problem
> as it has the same code duplication in bootm.c.
Progress! On PowerPC, does bootm work like before? I still have to
issue a separate 'bootm go', but that now boots, rather than hangs.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130628/6f81433d/attachment.pgp>
next prev parent reply other threads:[~2013-06-28 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 8:02 [U-Boot] [PATCH] Fix bootm to work on powerpc again (compressed uImage) Stefan Roese
2013-06-28 13:03 ` Tom Rini [this message]
2013-06-28 13:11 ` Stefan Roese
2013-06-28 21:46 ` Simon Glass
2013-06-28 22:08 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130628130322.GH28078@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox