From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] powerpc/c29xpcie: add support for C29XPCIE board
Date: Mon, 01 Jul 2013 11:54:15 +0200 [thread overview]
Message-ID: <20130701095415.9EE47380DF7@gemini.denx.de> (raw)
In-Reply-To: <1372661036-11828-2-git-send-email-y>
Dear y at tx30smr01.am.freescale.net,
In message <1372661036-11828-2-git-send-email-y> you wrote:
> From: Mingkai Hu <Mingkai.Hu@freescale.com>
>
> C29XPCIE board is a series of Freescale PCIe add-in cards to perform
> as public key crypto accelerator or secure key management module. It
> includes C293PCIE board, C293PCIE board and C291PCIE board.
>
> - 512KB platform SRAM in addition to 512K L2 Cache/SRAM
> - 512MB soldered DDR3 32bit memory
> - CPLD System Logic
> - 64MB x16 NOR flash and 4GB x8 NAND flash
> - 16MB SPI flash
>
> Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
> Singed-off-by: Po Liu <Po.Liu@freescale.com>
> ---
> Base on git://git.denx.de/u-boot.git
> board/freescale/c29xpcie/Makefile | 34 +++
> board/freescale/c29xpcie/c29xpcie.c | 150 +++++++++++
> board/freescale/c29xpcie/cpld.c | 155 ++++++++++++
> board/freescale/c29xpcie/cpld.h | 53 ++++
> board/freescale/c29xpcie/ddr.c | 89 +++++++
> board/freescale/c29xpcie/law.c | 22 ++
> board/freescale/c29xpcie/tlb.c | 89 +++++++
> boards.cfg | 2 +
> include/configs/C29XPCIE.h | 490 ++++++++++++++++++++++++++++++++++++
> 9 files changed, 1084 insertions(+)
> create mode 100644 board/freescale/c29xpcie/Makefile
> create mode 100644 board/freescale/c29xpcie/c29xpcie.c
> create mode 100644 board/freescale/c29xpcie/cpld.c
> create mode 100644 board/freescale/c29xpcie/cpld.h
> create mode 100644 board/freescale/c29xpcie/ddr.c
> create mode 100644 board/freescale/c29xpcie/law.c
> create mode 100644 board/freescale/c29xpcie/tlb.c
> create mode 100644 include/configs/C29XPCIE.h
Patch versionmissing.
History of pach changes missing.
Entry to MAINTAINERS file missing.
> +/*
> + * Internal Definitions
> + *
> + * Boot Flags
> + */
> +#define BOOTFLAG_COLD 0x01 /* Normal Power-On: Boot from FLASH */
> +#define BOOTFLAG_WARM 0x02 /* Software reboot */
Scott asked you before to clean up this file. Please do not simply
ignore review comments like that!!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Der Dativ ist dem Genitiv sein Tod.
next prev parent reply other threads:[~2013-07-01 9:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 6:43 [U-Boot] [PATCH 1/2] powerpc/85xx: Add C29x SoC support y at tx30smr01.am.freescale.net
2013-07-01 6:43 ` [U-Boot] [PATCH 2/2] powerpc/c29xpcie: add support for C29XPCIE board y at tx30smr01.am.freescale.net
2013-07-01 9:54 ` Wolfgang Denk [this message]
2013-07-01 9:45 ` [U-Boot] [PATCH 1/2] powerpc/85xx: Add C29x SoC support Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2013-06-26 7:23 Po Liu
2013-06-26 7:23 ` [U-Boot] [PATCH 2/2] powerpc/c29xpcie: add support for C29XPCIE board Po Liu
2013-06-26 19:33 ` Scott Wood
2013-04-24 7:14 [U-Boot] [PATCH 1/2] powerpc/85xx: Add C29x SoC support Po Liu
2013-04-24 7:14 ` [U-Boot] [PATCH 2/2] powerpc/c29xpcie: add support for C29XPCIE board Po Liu
2013-06-18 20:25 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701095415.9EE47380DF7@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox