public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] bmp: Respect "splashpos" if it is defined
Date: Tue, 2 Jul 2013 00:01:33 +0200	[thread overview]
Message-ID: <20130702000133.22279ec2@crub> (raw)
In-Reply-To: <1370541443-13184-1-git-send-email-otavio@ossystems.com.br>

Hello Otavio,

Sorry for delay.

On Thu,  6 Jun 2013 14:57:23 -0300
Otavio Salvador <otavio@ossystems.com.br> wrote:
...
> +#ifdef CONFIG_SPLASH_SCREEN_ALIGN
> +	s = getenv("splashpos");
> +	if (s != NULL) {
> +		if (s[0] == 'm')
> +			x = BMP_ALIGN_CENTER;
> +		else
> +			x = simple_strtol(s, NULL, 0);
> +
> +		s = strchr(s + 1, ',');
> +		if (s != NULL) {
> +			if (s[1] == 'm')
> +				y = BMP_ALIGN_CENTER;
> +			else
> +				y = simple_strtol(s + 1, NULL, 0);
> +		}
> +	}
> +#endif /* CONFIG_SPLASH_SCREEN_ALIGN */

This code is already there in two other drivers, we should better
add a common function for "splashpos" checking and use it here.
I'll submit a patch shortly.

Thanks,

Anatolij

  parent reply	other threads:[~2013-07-01 22:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06 17:57 [U-Boot] [PATCH] bmp: Respect "splashpos" if it is defined Otavio Salvador
2013-06-06 18:16 ` Otavio Salvador
2013-06-17 21:36 ` Otavio Salvador
2013-07-01 22:01 ` Anatolij Gustschin [this message]
2013-07-01 22:25   ` Otavio Salvador
2013-07-01 22:04 ` [U-Boot] [PATCH] video: consolidate splash screen alignment code Anatolij Gustschin
2013-07-01 22:24   ` Otavio Salvador
2013-07-08 18:47   ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130702000133.22279ec2@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox