From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Backport of DWC3 and xHCI stack from Linux kernel to uBoot
Date: Tue, 2 Jul 2013 23:55:21 +0200 [thread overview]
Message-ID: <201307022355.22210.marex@denx.de> (raw)
In-Reply-To: <20130702214305.B8D68380E10@gemini.denx.de>
Hello Wolfgang,
> Dear Dan Murphy,
>
> In message <1372778113-26053-1-git-send-email-dmurphy@ti.com> you wrote:
> > This patch series has been generated in an effort to get comments on
> > the implementation of the dwc and xHCI code within the uBoot.
>
> This patch series generates a number of checkpatch errors / warnings.
This is to be expected.
> OK, some of these (like the "Avoid CamelCase") relate to already
> existing code so there is little chance to fix them here and now, bot
> others (like "ERROR: trailing statements should be on next line",
> "WARNING: line over 80 characters", "CHECK: if this code is redundant
> consider removing it", "WARNING: Single statement macros should not
> use a do {} while (0) loop", "CHECK: memory barrier without comment",
> "WARNING: __packed is preferred over __attribute__((packed))", ...)
> should indeed be fixed.
Agreed. It'd be nice to fix the existing code in mainline Linux too btw.
Best regards,
Marek Vasut
prev parent reply other threads:[~2013-07-02 21:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 15:15 [U-Boot] Backport of DWC3 and xHCI stack from Linux kernel to uBoot Dan Murphy
2013-07-02 15:15 ` [U-Boot] [RFC] [UBOOT] [PATCH v3 1/7] USB: Backport kernel usb header file Dan Murphy
2013-07-02 15:18 ` Nishanth Menon
2013-07-02 15:23 ` Dan Murphy
2013-07-02 15:15 ` [U-Boot] [RFC] [UBOOT] [PATCH v3 2/7] USB: Adapt the usb-compat.h to uboot and fix compiler errors Dan Murphy
2013-07-02 15:15 ` [U-Boot] [RFC] [UBOOT] [PATCH v3 3/7] USB: Initial kernel back port of the dwc3 kernel code Dan Murphy
2013-07-02 15:15 ` [U-Boot] [RFC] [UBOOT] [PATCH v3 4/7] USB: dwc3: dwc3 code adaption for uBoot Dan Murphy
2013-07-02 15:15 ` [U-Boot] [RFC] [UBOOT] [PATCH v3 5/7] omap5: usb: Add usb otg clocks and enable Dan Murphy
2013-07-02 15:15 ` [U-Boot] [RFC] [UBOOT] [PATCH v3 6/7] USB: Add xhci linux kernel host driver Dan Murphy
2013-07-02 15:15 ` [U-Boot] [RFC] [UBOOT] [PATCH v3 7/7] USB: Modify the xHCI to adapt to the uBoot code base Dan Murphy
2013-07-02 21:43 ` [U-Boot] Backport of DWC3 and xHCI stack from Linux kernel to uBoot Wolfgang Denk
2013-07-02 21:55 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307022355.22210.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox