From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 2 Jul 2013 23:55:21 +0200 Subject: [U-Boot] Backport of DWC3 and xHCI stack from Linux kernel to uBoot In-Reply-To: <20130702214305.B8D68380E10@gemini.denx.de> References: <1372778113-26053-1-git-send-email-dmurphy@ti.com> <20130702214305.B8D68380E10@gemini.denx.de> Message-ID: <201307022355.22210.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, > Dear Dan Murphy, > > In message <1372778113-26053-1-git-send-email-dmurphy@ti.com> you wrote: > > This patch series has been generated in an effort to get comments on > > the implementation of the dwc and xHCI code within the uBoot. > > This patch series generates a number of checkpatch errors / warnings. This is to be expected. > OK, some of these (like the "Avoid CamelCase") relate to already > existing code so there is little chance to fix them here and now, bot > others (like "ERROR: trailing statements should be on next line", > "WARNING: line over 80 characters", "CHECK: if this code is redundant > consider removing it", "WARNING: Single statement macros should not > use a do {} while (0) loop", "CHECK: memory barrier without comment", > "WARNING: __packed is preferred over __attribute__((packed))", ...) > should indeed be fixed. Agreed. It'd be nice to fix the existing code in mainline Linux too btw. Best regards, Marek Vasut