From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Wed, 3 Jul 2013 15:30:20 +0200
Subject: [U-Boot] [PATCH] usb: fix unaligned access in device_qual()
In-Reply-To: <20130627185232.38359742@lilith>
References: <1372320297-16275-1-git-send-email-hs@denx.de>
	<201306271523.33879.marex@denx.de> <20130627185232.38359742@lilith>
Message-ID: <201307031530.20299.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Albert ARIBAUD,

> Hi Marek,
> 
> On Thu, 27 Jun 2013 15:23:33 +0200, Marek Vasut <marex@denx.de> wrote:
> > Hello Albert,
> > 
> > > Hi Marek,
> > > 
> > > On Thu, 27 Jun 2013 13:26:39 +0200, Marek Vasut <marex@denx.de> wrote:
> > > > Dear Heiko Schocher,
> > > > 
> > > > > while playing with dfu, I tapped in an unaligned access
> > > > > when doing on the host side a "lsusb -d [vendornr]: -v"
> > > > 
> > > > > I get on the board:
> > > > Applied, thanks
> > > 
> > > Now we have console log output in commit messages. :(
> > 
> > Don't be sad, I will buy you a tartelette ;)
> 
> Actually the sad part is that the patch in itself is bad: the actual
> alignment boundary should have been 16 bit, not one cacheline. Also,
> the issue could / should have been solved by reordering the fields
> rather than using an attribute.

Why 16 bit? I think cacheline alignment here makes sense if the descriptor is to 
be flush()'d from dcache.

> And I'm not going to eat a tartelette when I'm about 30 minutes from
> going to a restaurant (admittedly small, but undoubtedly near).

You should have one to survive the journey ;-)

Best regards,
Marek Vasut