[U-Boot] [U-boot] DFU tools copyright

[U-Boot] [U-boot] DFU tools copyright

[TigerLiu at viatech.com.cn]

Hi, experts:
I found DFU tool code had been put in drivers/dfu directory.
Previously, it was owned by Samsung Electronics.

Because it has been merged into uboot library.
So, it could be used or released by every ARM SOC vendor?

Best wishes,

[U-Boot] [U-boot] DFU tools copyright

[Lukasz Majewski]

On Thu, 04 Jul 2013 17:20:34 +0800, TigerLiu at viatech.com.cn wrote:

> Hi, experts:
> I found DFU tool code had been put in drivers/dfu directory.
> Previously, it was owned by Samsung Electronics.
> 

Could you be more specific here? 

All DFU related files have following headers:
/*
 * g_dnl.c -- USB Downloader Gadget
 *
 * Copyright (C) 2012 Samsung Electronics
 * Lukasz Majewski  <l.majewski@samsung.com>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307  USA */

Which clearly states that the code is GPL v2+. The code is "open", you
can modify it and use with your product if you provide your's product
source code when requested.


> Because it has been merged into uboot library.
> So, it could be used or released by every ARM SOC vendor?

Yes, it can as long as this vendor sticks to GPL v2 license.
This mean (with some simplification :-) ) that this vendor needs to
publish source code for his product.

> 
> Best wishes,
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot


-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

[U-Boot] [U-boot] DFU tools copyright

[Stefan Schmidt]

Hello.

On Thu, 2013-07-04 at 11:37, Lukasz Majewski wrote:
> On Thu, 04 Jul 2013 17:20:34 +0800, TigerLiu at viatech.com.cn wrote:
> 
> > Hi, experts:
> > I found DFU tool code had been put in drivers/dfu directory.
> > Previously, it was owned by Samsung Electronics.
> > 
> 
> Could you be more specific here? 
> 
> All DFU related files have following headers:
> /*
>  * g_dnl.c -- USB Downloader Gadget
>  *
>  * Copyright (C) 2012 Samsung Electronics
>  * Lukasz Majewski  <l.majewski@samsung.com>

Which reminds about an issue I brought up before. Your DFU
implementation is heavily based on the original DFU code Harald Welte
wrote. The state machine even still have the same fixmes and comments
but you removed his, and maybe others, copyright here.

As you definitely not wrote the code from scratch you should keep the
original copyright intact and not only placing the Samsung copyright
here.

regards
Stefan Schmidt

[U-Boot] [U-boot] DFU tools copyright

[Lukasz Majewski]

On Thu, 04 Jul 2013 22:08:12 +0100, Stefan Schmidt wrote:
> Hello.
> 
> On Thu, 2013-07-04 at 11:37, Lukasz Majewski wrote:
> > On Thu, 04 Jul 2013 17:20:34 +0800, TigerLiu at viatech.com.cn wrote:
> > 
> > > Hi, experts:
> > > I found DFU tool code had been put in drivers/dfu directory.
> > > Previously, it was owned by Samsung Electronics.
> > > 
> > 
> > Could you be more specific here? 
> > 
> > All DFU related files have following headers:
> > /*
> >  * g_dnl.c -- USB Downloader Gadget
> >  *
> >  * Copyright (C) 2012 Samsung Electronics
> >  * Lukasz Majewski  <l.majewski@samsung.com>
> 
> Which reminds about an issue I brought up before. Your DFU
> implementation is heavily based on the original DFU code Harald Welte
> wrote. The state machine even still have the same fixmes and comments
> but you removed his, and maybe others, copyright here.
> 

You are right here. The state machine was only slightly modified by us.

I will update the f_dfu.c file accordingly to bring back proper credits.

I'm sorry for the situation - it was not intentional.

> As you definitely not wrote the code from scratch you should keep the
> original copyright intact and not only placing the Samsung copyright
> here.
> 
> regards
> Stefan Schmidt
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot


-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

[U-Boot] [U-boot] DFU tools copyright

[Stefan Schmidt]

Hello.

> On Thu, 04 Jul 2013 22:08:12 +0100, Stefan Schmidt wrote:
>> Hello.
>>
>> On Thu, 2013-07-04 at 11:37, Lukasz Majewski wrote:
>> > On Thu, 04 Jul 2013 17:20:34 +0800, TigerLiu at viatech.com.cn wrote:
>> >
>> > > Hi, experts:
>> > > I found DFU tool code had been put in drivers/dfu directory.
>> > > Previously, it was owned by Samsung Electronics.
>> > >
>> >
>> > Could you be more specific here?
>> >
>> > All DFU related files have following headers:
>> > /*
>> >  * g_dnl.c -- USB Downloader Gadget
>> >  *
>> >  * Copyright (C) 2012 Samsung Electronics
>> >  * Lukasz Majewski  <l.majewski@samsung.com>
>>
>> Which reminds about an issue I brought up before. Your DFU
>> implementation is heavily based on the original DFU code Harald Welte
>> wrote. The state machine even still have the same fixmes and comments
>> but you removed his, and maybe others, copyright here.
>>
>
> You are right here. The state machine was only slightly modified by us.
>
> I will update the f_dfu.c file accordingly to bring back proper credits.

Cool. The patchset I sent April 2012 which was for reference only should
have the correct credits in the old_dfu.c file.
http://lists.denx.de/pipermail/u-boot/2012-April/121864.html

> I'm sorry for the situation - it was not intentional.

No worries. This was not meant to blame anyone. Just something that needs
correction. Just took the change to remind about it. :)

regards
Stefan Schmidt

[U-Boot] [PATCH] dfu: Update DFU's authorship history

[Lukasz Majewski]

The DFU's state machine original implementation author and copyright were
missing.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
---
 drivers/usb/gadget/f_dfu.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
index e3fa0e3..6adf15c 100644
--- a/drivers/usb/gadget/f_dfu.c
+++ b/drivers/usb/gadget/f_dfu.c
@@ -5,6 +5,10 @@
  * authors: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
  *          Lukasz Majewski <l.majewski@samsung.com>
  *
+ * Based on OpenMoko u-boot: drivers/usb/usbdfu.c
+ * (C) 2007 by OpenMoko, Inc.
+ * Author: Harald Welte <laforge@openmoko.org>
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
-- 
1.7.10.4

[U-Boot] [PATCH] dfu: Update DFU's authorship history

[Stefan Schmidt]

Hello.

> The DFU's state machine original implementation author and copyright were
> missing.
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> ---
>  drivers/usb/gadget/f_dfu.c |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
> index e3fa0e3..6adf15c 100644
> --- a/drivers/usb/gadget/f_dfu.c
> +++ b/drivers/usb/gadget/f_dfu.c
> @@ -5,6 +5,10 @@
>   * authors: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
>   *          Lukasz Majewski <l.majewski@samsung.com>
>   *
> + * Based on OpenMoko u-boot: drivers/usb/usbdfu.c
> + * (C) 2007 by OpenMoko, Inc.
> + * Author: Harald Welte <laforge@openmoko.org>
> + *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
>   * the Free Software Foundation; either version 2 of the License, or
> --
> 1.7.10.4

You missed Haralds personal copyright from 2006.
+ * based on existing SAM7DFU code from OpenPCD:
+ * (C) Copyright 2006 by Harald Welte <hwelte@hmw-consulting.de>

While he was working on this for OpenMoko which gives them the copyright
he did work on this code before which means his own copyright does also
apply.

regards
Stefan Schmidt

[U-Boot] [PATCH v2] dfu: Update DFU's authorship history

[Lukasz Majewski]

The DFU's state machine original implementation author and copyright were
missing.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>

---
Changes for v2:
- Add the whole Harald's development history
---
 drivers/usb/gadget/f_dfu.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
index e3fa0e3..d7ae0c0 100644
--- a/drivers/usb/gadget/f_dfu.c
+++ b/drivers/usb/gadget/f_dfu.c
@@ -5,6 +5,13 @@
  * authors: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
  *          Lukasz Majewski <l.majewski@samsung.com>
  *
+ * Based on OpenMoko u-boot: drivers/usb/usbdfu.c
+ * (C) 2007 by OpenMoko, Inc.
+ * Author: Harald Welte <laforge@openmoko.org>
+ *
+ * based on existing SAM7DFU code from OpenPCD:
+ * (C) Copyright 2006 by Harald Welte <hwelte@hmw-consulting.de>
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
-- 
1.7.10.4

[U-Boot] [PATCH v2] dfu: Update DFU's authorship history

[Stefan Schmidt]

Hello.

> The DFU's state machine original implementation author and copyright were
> missing.
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>

Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>

>
> ---
> Changes for v2:
> - Add the whole Harald's development history
> ---
>  drivers/usb/gadget/f_dfu.c |    7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
> index e3fa0e3..d7ae0c0 100644
> --- a/drivers/usb/gadget/f_dfu.c
> +++ b/drivers/usb/gadget/f_dfu.c
> @@ -5,6 +5,13 @@
>   * authors: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
>   *          Lukasz Majewski <l.majewski@samsung.com>
>   *
> + * Based on OpenMoko u-boot: drivers/usb/usbdfu.c
> + * (C) 2007 by OpenMoko, Inc.
> + * Author: Harald Welte <laforge@openmoko.org>
> + *
> + * based on existing SAM7DFU code from OpenPCD:
> + * (C) Copyright 2006 by Harald Welte <hwelte@hmw-consulting.de>
> + *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
>   * the Free Software Foundation; either version 2 of the License, or
> --
> 1.7.10.4

regards
Stefan Schmidt