From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 4 Jul 2013 14:09:09 +0200 Subject: [U-Boot] [PATCH 3/3] Makefile: fix readelf usage In-Reply-To: <1372590906-75089-4-git-send-email-andreas.devel@googlemail.com> References: <1372590906-75089-1-git-send-email-andreas.devel@googlemail.com> <1372590906-75089-4-git-send-email-andreas.devel@googlemail.com> Message-ID: <20130704140909.473d6092@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andreas, On Sun, 30 Jun 2013 13:15:06 +0200, Andreas Bie?mann wrote: > Some OS (like OS X) do not provide a generic readelf. We should enforce to use > the toochain provided readelf instead, to do so use $(CROSS_COMPILE)readelf. > > Signed-off-by: Andreas Bie?mann > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index ba1c10b..446c2f8 100644 > --- a/Makefile > +++ b/Makefile > @@ -747,7 +747,7 @@ endif # config.mk > # ARM relocations should all be R_ARM_RELATIVE. > checkarmreloc: $(obj)u-boot > @if test "R_ARM_RELATIVE" != \ > - "`readelf -r $< | cut -d ' ' -f 4 | grep R_ARM | sort -u`"; \ > + "`$(CROSS_COMPILE)readelf -r $< | cut -d ' ' -f 4 | grep R_ARM | sort -u`"; \ > then echo "$< contains relocations other than \ > R_ARM_RELATIVE"; false; fi Acked-by: Albert ARIBAUD Tom, do I take this in u-boot-arm and then deliver this later in my PR, or do you want to pick it directly in mainline? Amicalement, -- Albert.