[U-Boot] [RESEND PATCH 1/4] arm:goni: Update configuration for goni target

[Lukasz Majewski <l.majewski@samsung.com>]

On Fri, 05 Jul 2013 13:17:07 +0900, Jaehoon Chung wrote:
> On 07/04/2013 07:52 PM, Lukasz Majewski wrote:
> > From: Arkadiusz Wlodarczyk <a.wlodarczyk@samsung.com>
> > 
> > Configuration file for GONI has been updated to support FAT file
> > system, new mmc partitioning scheme and read linux kernel from eMMC
> > instead of OneNAND.
> > 
> > Signed-off-by: Arkadiusz Wlodarczyk <a.wlodarczyk@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > Tested-by: Arkadiusz Wlodarczyk <a.wlodarczyk@samsung.com>
> > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > ---
> >  include/configs/s5p_goni.h |   17 +++++++++++++----
> >  1 file changed, 13 insertions(+), 4 deletions(-)
> > 
> > diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
> > index 56e8347..ec43652 100644
> > --- a/include/configs/s5p_goni.h
> > +++ b/include/configs/s5p_goni.h
> > @@ -107,7 +107,7 @@
> >  
> >  #define NORMAL_MTDPARTS_DEFAULT MTDPARTS_DEFAULT
> >  
> > -#define CONFIG_BOOTCOMMAND	"run ubifsboot"
> > +#define CONFIG_BOOTCOMMAND	"run mmcboot"
> >  
> >  #define CONFIG_DEFAULT_CONSOLE	"console=ttySAC2,115200n8\0"
> >  
> > @@ -137,7 +137,7 @@
> >  		"onenand erase 0x01560000 0x1eaa0000;" \
> >  		"onenand write 0x32000000 0x1260000 0x8C0000\0" \
> >  	"bootk=" \
> > -		"onenand read 0x30007FC0 0xc00000 0x600000;" \
> > +		"run loaduimage;" \
> >  		"bootm 0x30007FC0\0" \
> >  	"flashboot=" \
> >  		"set bootargs root=/dev/mtdblock${bootblock} " \
> > @@ -156,16 +156,21 @@
> >  		"set bootargs " CONFIG_RAMDISK_BOOT \
> >  		" initrd=0x33000000,8M ramdisk=8192\0" \
> >  	"mmcboot=" \
> > -		"set bootargs root=${mmcblk}
> > rootfstype=${rootfstype}" \
> > +		"set bootargs
> > root=/dev/mmcblk${mmcdev}p${mmcrootpart} " \
> > +		"rootfstype=${rootfstype}" \
> Could you add the "rootwait"?

Yes, correct. Thanks for pointing.

> >  		CONFIG_UBI_MTD " ${opts} ${lcdinfo} " \
> >  		CONFIG_COMMON_BOOT "; run bootk\0" \
> >  	"boottrace=setenv opts initcall_debug; run bootcmd\0" \
> >  	"bootchart=set opts init=/sbin/bootchartd; run bootcmd\0" \
> >  	"verify=n\0" \
> > -	"rootfstype=cramfs\0" \
> > +	"rootfstype=ext4\0" \
> >  	"console=" CONFIG_DEFAULT_CONSOLE \
> >  	"mtdparts=" MTDPARTS_DEFAULT \
> >  	"meminfo=mem=80M mem=256M at 0x40000000
> > mem=128M at 0x50000000\0" \
> > +	"loaduimage=fatload mmc ${mmcdev}:${mmcbootpart}
> > 0x30007FC0 uImage\0" \
> > +	"mmcdev=0\0" \
> > +	"mmcbootpart=2\0" \
> > +	"mmcrootpart=5\0" \
> >  	"mmcblk=/dev/mmcblk1p1\0" \
> mmcblk can be removed?

Yes, it seems redundant here.


> 
> Best Regards,
> Jaehoon Chung
> >  	"bootblock=9\0" \
> >  	"ubiblock=8\0" \
> > @@ -211,6 +216,10 @@
> >  
> >  #define CONFIG_DOS_PARTITION		1
> >  
> > +/* FAT */
> > +#define CONFIG_CMD_FAT
> > +#define CONFIG_FAT_WRITE
> > +
> >  #define CONFIG_SYS_INIT_SP_ADDR	(CONFIG_SYS_LOAD_ADDR -
> > 0x1000000) 
> >  #define CONFIG_SYS_CACHELINE_SIZE       64
> > 
> 

Thanks for review.

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group