From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-boot] DFU tools copyright
Date: Fri, 05 Jul 2013 10:42:18 +0200 [thread overview]
Message-ID: <20130705104218.4ecda1ae@amdc308.digital.local> (raw)
In-Reply-To: <20130704210812.GD6180@novatech.datenfreihafen.org>
On Thu, 04 Jul 2013 22:08:12 +0100, Stefan Schmidt wrote:
> Hello.
>
> On Thu, 2013-07-04 at 11:37, Lukasz Majewski wrote:
> > On Thu, 04 Jul 2013 17:20:34 +0800, TigerLiu at viatech.com.cn wrote:
> >
> > > Hi, experts:
> > > I found DFU tool code had been put in drivers/dfu directory.
> > > Previously, it was owned by Samsung Electronics.
> > >
> >
> > Could you be more specific here?
> >
> > All DFU related files have following headers:
> > /*
> > * g_dnl.c -- USB Downloader Gadget
> > *
> > * Copyright (C) 2012 Samsung Electronics
> > * Lukasz Majewski <l.majewski@samsung.com>
>
> Which reminds about an issue I brought up before. Your DFU
> implementation is heavily based on the original DFU code Harald Welte
> wrote. The state machine even still have the same fixmes and comments
> but you removed his, and maybe others, copyright here.
>
You are right here. The state machine was only slightly modified by us.
I will update the f_dfu.c file accordingly to bring back proper credits.
I'm sorry for the situation - it was not intentional.
> As you definitely not wrote the code from scratch you should keep the
> original copyright intact and not only placing the Samsung copyright
> here.
>
> regards
> Stefan Schmidt
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2013-07-05 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 9:20 [U-Boot] [U-boot] DFU tools copyright TigerLiu at viatech.com.cn
2013-07-04 9:37 ` Lukasz Majewski
2013-07-04 21:08 ` Stefan Schmidt
2013-07-05 8:42 ` Lukasz Majewski [this message]
2013-07-05 9:07 ` Stefan Schmidt
2013-07-05 9:23 ` [U-Boot] [PATCH] dfu: Update DFU's authorship history Lukasz Majewski
2013-07-05 9:28 ` Stefan Schmidt
2013-07-05 9:40 ` [U-Boot] [PATCH v2] " Lukasz Majewski
2013-07-05 9:44 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130705104218.4ecda1ae@amdc308.digital.local \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox